Switch to root logger in setup_logging#133
Merged
PicoCentauri merged 5 commits intomainfrom Jan 22, 2026
Merged
Conversation
PicoCentauri
approved these changes
Jan 22, 2026
- Clarify setup_logging - don't filter warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way
mdacli.logger.setup_loggingworks.Since mdacli is invoked from the command line, we do not need to worry about handling different loggers. To make things simpler and less error-prone, the method was changed to only work on the root logger.
Software that uses mdacli just configures its loggers (see https://docs.python.org/3/library/logging.html#logger-objects for details on how this should be done) and the logs propagate to the root logger and get handled by mdacli.
📚 Documentation preview 📚: https://mdacli--133.org.readthedocs.build/en/133/