-
Notifications
You must be signed in to change notification settings - Fork 769
Remove nose references #5212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Remove nose references #5212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes all references to the nose testing framework from the MDAnalysis codebase, completing the migration to pytest.
Changes:
- Removed nose dependency from benchmarking configuration
- Removed nose-specific ignore patterns from version control
- Removed outdated nose-related comments from test files
- Added contributor name to AUTHORS file
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.gitignore |
Removed .noseids entry, which was specific to the nose test runner |
benchmarks/asv.conf.json |
Removed nose from the benchmark dependencies list |
testsuite/MDAnalysisTests/utils/test_streamio.py |
Removed outdated comments referencing nose verbose output |
package/AUTHORS |
Added "Khushi Phougat" to the 2026 contributors list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5212 +/- ##
========================================
Coverage 92.72% 92.73%
========================================
Files 180 180
Lines 22475 22475
Branches 3190 3190
========================================
+ Hits 20841 20843 +2
+ Misses 1177 1176 -1
+ Partials 457 456 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @khushi-phougat, welcome to MDAnalysis! 🎉😊 I was just going through the PRs and pulled this locally to test. The cleanup looks really solid—I searched through the files and verified that all the nose-related configs are gone LGTM 🙌. |
|
Hi @IAyaanHere , thank you for the welcome and for taking the time to review this. As this was my first contribution, I chose a really straightforward issue just to understand things, and was actually really doubtful if I'm doing it right or not. Happy to hear that this looks good :) |
Fixes #5085
Changes made in this Pull Request:
LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: no
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5212.org.readthedocs.build/en/5212/