Conversation
Fixing: ``` Python Error: ImportError: DLL load failed while importing pyexpat: The operating system cannot run %1. ```
Fix Failing Tests:
* Unix/MacOS:
* Pin Ubuntu version to `ubuntu-22.04`
* Explicitly set LD_PRELOAD environment variable
* Skip Failing:
* Ubuntu, python 3.10, matlab R2023a
* All other matrix tests pass
* Windows:
* Set PYBIND11_NO_ASSERT_GIL_HELD_INCREF_DECREF=1
* Attempt to fix python call from MATLAB
* Skip:
* Python 3.10 R2023a
The get(0,'Format') calls were originally added to support debugging printf statements (now removed). Since format only affects display and not calculation precision, these commands are unnecessary for the programmatic numerical comparisons performed by these methods.
…onversion - Replace datestr() with string() for datetime formatting - Replace datenum(datestr()) with direct datenum() conversion for performance - Maintains same output formats while using modern MATLAB functions
…iles - Remove unused datenum variables in QC_Test.m - Replace datenum arithmetic with datetime operations and seconds() conversion - Replace Unix epoch conversion with posixtime in River_TestIO.m
- Update plot_joint_probability_distribution.m to use colormap(CMaPType, 256) - Update plot_rose.m to use colormap(CMaPType, 256) - Update plot_matrix.m to use colormap(flipud(hot(256))) This ensures consistent behavior across MATLAB versions and uses the modern 256-color standard instead of the legacy 64-color default.
Acoustics Module Standardization
Acoustics module
WEC-Sim Power performance example
Feature: Add Dolfyn Turbulence Functionality
Prep v1.0 release
hivanov-nrel
approved these changes
Sep 30, 2025
Contributor
hivanov-nrel
left a comment
hivanov-nrel
left a comment
There was a problem hiding this comment.
At a high level, looks good to me. In the future, we should figure out a solid method for keeping track of all the changes to make release note generation easier. I think we are good to merge assuming all the tests pass!
Contributor
Author
|
@hivanov-nrel, thank you for reviewing! Agreed on the release notes. It seems possible to create a template for each pull request. I can look into that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 1.0.0
Release Highlights
PR #174 - Acoustics Module
plot_spectrogramPR #176 - Wave Module Native MATLAB Implementation
PR #153 - Mooring Module
PR #173 - Dolfyn Turbulence Functionality
PR #175 - WEC-Sim Power Performance Example
PR #170 - WDRT Final Tasks
automatic_hs_thresholdandreturn_year_valuefunctionsPR #169 - Code Compatibility Improvements
Bug Fixes
environmental_contours_example.mlxdue tospectra_to_pandasreturn variable #152 - Fix dimensionality differences in environmental_contours_example - @simmsa