Actions: Migrate to newer versions of macos#194
Draft
simmsa wants to merge 55 commits intoMHKiT-Software:developfrom
Draft
Actions: Migrate to newer versions of macos#194simmsa wants to merge 55 commits intoMHKiT-Software:developfrom
simmsa wants to merge 55 commits intoMHKiT-Software:developfrom
Conversation
macos-13 runners are "retired": actions/runner-images#13046
simmsa
force-pushed
the
fix_actions_macos_versions
branch
from
460e50f to
34d24a9
Compare
Bash consistently uses UTF-8. Using powershell here may break the encoding of run.m causing downstream code to fail transparently.
This is caused by a change in mhkit-python where the bin edges went from infinite to a fixed value. Effectively previous mhkit-python versions squeezed every value between the users spec second to last bin and infinity. This caused a reduced nan count here. Filtering the bins outside of the specified max range increases the nan count, and specifically to 45 for these test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macos-13 runners are "retired": actions/runner-images#13046