adaptions to test scripts#74
Merged
skinkie merged 19 commits intobinary_relation_serializerfrom Jan 8, 2026
Merged
Conversation
Contributor
|
@ue71603 the fundamental problem that I had running the code was that the path towards the XML Schema was wrong. I don't get any error afterwards. |
Contributor
|
Maybe you can print the path around line 114? |
Collaborator
Author
|
@skinkie Thanks for fixing the path. However, I still get the error. Do I need to regenerate schema and model again. Also perhaps I don't have the excact mdbx as you do or a library not installed. |
Contributor
|
You get an error about the path length, please print the path before the error. |
Collaborator
Author
|
It obviously is not the length ot the paths.. I added the code and it does show Does python -m tools.script_runner ./tools/tool_scripts/script_regression_basic.txt mylog.log nl_filter work with you? I added some more code to show what the keys are. ChatGPT suggest that the problem lies deeper and then the error is created later. Which libmdbx do you use? |
Contributor
|
I was running libmdbx 0.2.1, upgrade to 0.3.1. This is my output: |
Contributor
|
@ue71603 you have hardcoded somewhere in the code that the logging should go do "d:". No clue where this happens yet. So that is configuration.py. Validate that if a non existing Microsoft Windows drive is specified that the code won't break. |
Contributor
|
Can repoduce the "filename too long" error on Windows. |
Contributor
|
In your local code open mdbx.py (for example by clicking on TXN). Search for MDBX_ENODATA, replace the list with this one below. MDBX_ENODATA = 38
MDBX_EINVAL = 87
MDBX_EACCES = 5
MDBX_ENOMEM = 14
MDBX_EROFS = 6008
MDBX_ENOSYS = 50
MDBX_EIO = 29
MDBX_EPERM = 1
MDBX_EINTR = 1223
MDBX_ENOFILE = 2
MDBX_EREMOTE = 4352Pull request upstream: wtdcode/mdbx-py#14 |
skinkie
reviewed
Dec 28, 2025
skinkie
reviewed
Dec 28, 2025
skinkie
reviewed
Dec 28, 2025
transformers/gtfs.py
Outdated
| ) | ||
| from domain.netex.model.name_of_class_operating_period_ref_structure import NameOfClassOperatingPeriodRefStructure | ||
| #TODO remove as an correct | ||
| from domain.netex.model.name_of_class_operating_period_ref_structure_type import NameOfClassOperatingPeriodRefStructureType as NameOfClassOperatingPeriodRefStructure |
Contributor
There was a problem hiding this comment.
Please elaborate why the renaming is done.
Collaborator
Author
There was a problem hiding this comment.
@skinkie it seems that now all are _type in the end. In this file they were not. So i changed the import, but not yet the content of gtfs.py. At least in my version. Or is something wrong with my model again (regenerated it before I started)
skinkie
reviewed
Dec 28, 2025
transformers/gtfs.py
Outdated
| # TODO: ResponsibilitySet to Operator/Authority should be a separate function | ||
| responsibility_set = cast( | ||
| ResponsibilitySet, db_read.load_object_by_reference(txn, getFakeRef(line.responsibility_set_ref_attribute, ResponsibilitySetRef)) | ||
| ResponsibilitySet, db_read.load_object_by_reference(txn, getFakeRef(line.responsibility_set_ref_attribute, ResponsibilitySetRef,line.version)) |
Contributor
There was a problem hiding this comment.
black would have saved the humilation!
Suggested change
| ResponsibilitySet, db_read.load_object_by_reference(txn, getFakeRef(line.responsibility_set_ref_attribute, ResponsibilitySetRef,line.version)) | |
| ResponsibilitySet, db_read.load_object_by_reference(txn, getFakeRef(line.responsibility_set_ref_attribute, ResponsibilitySetRef, line.version)) |
But I wonder why we give responsibilityset a version at all.
Collaborator
Author
There was a problem hiding this comment.
I don't know, but it wants to get a version parameter.
sorry forgot to remove it Co-authored-by: Stefan de Konink <stefan@konink.de>
Co-authored-by: Stefan de Konink <stefan@konink.de>
…eType in epip.py - fixed getId in two files, - fixed NameOfClassOperatingPEriodRefStructureType in epip.py
Contributor
|
I'll merge when I am done with the branch. |
…rk for validation
as route_desc is hard-coded in the select, it would break otherwise later in the next step. However, you need to check if this is ok with your code.
* SKIPLUS-1116: remove repleated lines. * SKIPLUS-1116: adapt example about how to run xml_validator from command line.
…th the same properties as they were created
# Conflicts: # transformers/gtfs.py
Contributor
|
@ue71603 ready to merge this branch? |
Collaborator
Author
|
@skinkie we can merge this into binary... The other problem I am still analysing but we recreate the branch.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@skinkie Can you check, why
the script ./tool_scripts/script_regression_basic.txt mylog.log nl_filter
produces this error:
something wrong with the definition?