Fixing next serie of small problems (mainly found while handling Swiss data and filter) by ue71603 · Pull Request #92 · MMTIS/badger

ue71603 · 2026-01-16T23:42:44Z

Direction handled in the yield differently. This way it gets exported.
Reordered arguments in filter_db_to_db.py (same as used in the script_runner)
Handling the problem that Swiss JourneyMeeting and InterchangeRule don't result in valid ServiceJourneyInterchange (the only thing allowed in EPIP). We will discuss doing and transforming things with MENTZ.
commit to check by Stefan: 6a779c9
Adapting tests to do what is needed here
Fix a problem in test_runner.py

When we automatically generate direction, we need to store it. reorganised the yielding.

transformers/direction.py

storage/lxml/core/insert.py

produces tons of log comments

allowed according to the epiprepository. also added a missing import: recurisve_attributes

…MMTIS/badger into fixing_direction_problem_filter

skinkie · 2026-01-20T10:24:59Z

I'll revamp this branch later.

skinkie · 2026-01-20T19:12:05Z

3022cfb @ue71603 unrelated!!

transformers/epip.py

…MMTIS/badger into fixing_direction_problem_filter

…problem_filter

…em_filter

…the data

…t-runner-cli

Installable badger-script-runner CLI script

SNCF already contained ":Line:" in the route_id and therefore between the id of Line and the ref in ServiceJourney the behaviour was different and it never matched again.

ue71603 added 3 commits January 17, 2026 00:38

adding new filter test draft

81b6637

stefan: suggestion to not create Direction

2eda334

really saving direction when automatically generated

bae480f

When we automatically generate direction, we need to store it. reorganised the yielding.

ue71603 added this to the 2.0 milestone Jan 16, 2026

ue71603 added 2 commits January 17, 2026 01:00

changing order of arguments in filter_db_to_db.py target now second

237d034

fixing problem in filter1

124457c

skinkie reviewed Jan 17, 2026

View reviewed changes

transformers/direction.py Outdated Show resolved Hide resolved

ue71603 added 3 commits January 17, 2026 12:39

stefan: everything with yield now

d8b82d9

Update script_regression_v1.1.txt

2c10ed1

stefan: no forced order (if ok for you)

06ae4e2

skinkie reviewed Jan 17, 2026

View reviewed changes

storage/lxml/core/insert.py Outdated Show resolved Hide resolved

ue71603 added 13 commits January 17, 2026 13:36

stefan: some changes, to epip.py that you should check

6a779c9

order again written

4e162dd

produces tons of log comments

updating testing

47cd374

Update script_regression_v1.1.txt

dba721e

Update script_swiss_prod.txt

c5bfa52

rstrip is not to be used for this, removesuffix is the one needed

fb1987c

changing tests

74cad9e

stefan: keeping journey_meeting_and_interchangerule in the files

475ae58

allowed according to the epiprepository. also added a missing import: recurisve_attributes

updating tests

437074e

update scripts

e72e051

Update script_swiss_prod.txt

05e47e8

Update meta_test.txt

b37ac1d

Merge branch 'fixing_direction_problem_filter' of https://github.com/…

670e5cf

…MMTIS/badger into fixing_direction_problem_filter

ue71603 changed the title ~~Trying to fix the problem with Direction~~ Fixing next step of problem Jan 20, 2026

ue71603 changed the title ~~Fixing next step of problem~~ Fixing next serie of small problems (mainly found while handling Swiss data and filter) Jan 20, 2026

skinkie reviewed Jan 21, 2026

View reviewed changes

transformers/epip.py Outdated Show resolved Hide resolved

adding new filter test draft

2ad02be

ue71603 and others added 30 commits February 2, 2026 09:49

Merge branch 'fixing_direction_problem_filter' of https://github.com/…

f8c64ef

…MMTIS/badger into fixing_direction_problem_filter

improving preproc

b6f408c

working on preproc

8e32679

Merge branch 'fixing_direction_problem_filter' of https://github.com/…

7ddd47b

…MMTIS/badger into fixing_direction_problem_filter

continue on cleanup

5b69a13

fixing file handler

0171123

Merge branch 'fixing_direction_problem_filter' of https://github.com/…

79b267f

…MMTIS/badger into fixing_direction_problem_filter

Update netex_uicoperatingperiod_correction.py

1220243

Stefan: problem with GTFS, when no coordinates

8bc0c3b

Merge remote-tracking branch 'origin/fix_gtfs' into fixing_direction_…

77188b5

…problem_filter

improving tests

6175667

improve preproc for fr

d67937e

processing fr_sncf_ter and making adaptions for it.

4b1ace3

Merge remote-tracking branch 'origin/fix_gtfs' into fixing_direction_…

2e4e634

…problem_filter

continue sncf work

d7d1078

Merge remote-tracking branch 'origin/fix_gtfs' into fixing_direction_…

ae6ea7b

…problem_filter

Provide script badger-script-runner, installable with uv pip install.

fa0d2b4

Revert unwanted changes of meta_test.txt.

5a11f99

Merge branch 'binary_relation_serializer' into fixing_direction_probl…

7d3d651

…em_filter

Add description of the Badger CLI scripts installation/usage.

8b13879

working on tests

de56700

Stefan: Needed to get a new direction in time

c0add4f

update problem list

920d1cd

Update script_regression_v1.1.txt

cc7115e

change tests

0564204

Stefan: Fixing a problem in the case when there is a FlexibleLine in …

91b5668

…the data

Merge branch 'fixing_direction_problem_filter' into installable-scrip…

54fbb6b

…t-runner-cli

Merge pull request #105 from MMTIS/installable-script-runner-cli

aff52a9

Installable badger-script-runner CLI script

improving testing

af52fad

fixing a problem in fr_sncf_gtfs

ec56b40

SNCF already contained ":Line:" in the route_id and therefore between the id of Line and the ref in ServiceJourney the behaviour was different and it never matched again.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing next serie of small problems (mainly found while handling Swiss data and filter)#92

Fixing next serie of small problems (mainly found while handling Swiss data and filter)#92
ue71603 wants to merge 127 commits intobinary_relation_serializerfrom
fixing_direction_problem_filter

ue71603 commented Jan 16, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

skinkie commented Jan 20, 2026

Uh oh!

skinkie commented Jan 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ue71603 commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skinkie commented Jan 20, 2026

Uh oh!

skinkie commented Jan 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ue71603 commented Jan 16, 2026 •

edited

Loading