Performance: optimize buffer handling, eliminate redundant operations, add retry limits

[Copilot]

Closes: Identify and suggest improvements to slow or inefficient code

Description

Identified and fixed performance bottlenecks across server and client code:

Server optimizations:

• Cache crypto module instead of requiring on every request (index.js)
• Replace data += chunk with Buffer.concat() for streaming responses (engineClient.js, portainerClient.js)
• Add retry limits to prevent infinite recursion on auth failures (qbittorrentClient.js)
• Pre-calculate BYTES_TO_GB constant to avoid repeated arithmetic (containers.js)
• Consolidate CPU calculation logic using existing utility (containers.js)
• Wrap WebSocket sends in try-catch to handle closed connections (logs.js)

Client optimizations:

• Extract parseDockerStats() helper to eliminate duplicate parsing logic (app.js, docs/app.js)
• Add actionInProgress flag to prevent concurrent container action race conditions
• Replace forEach with for loops in hot paths (logs.js)

Example - Buffer optimization:

// Before: inefficient string concatenation
res.on('data', chunk => data += chunk);

// After: efficient buffer collection
const chunks = [];
res.on('data', chunk => chunks.push(chunk));
res.on('end', () => {
  const data = Buffer.concat(chunks).toString();
  // ...
});

Impact:

• Reduced memory allocations and GC pressure
• Eliminated ~100 lines of duplicated code
• Prevented potential infinite loops and race conditions
• Improved error resilience for WebSocket connections

Tradeoffs:

• Global actionInProgress flag prevents all concurrent container actions system-wide. Per-container locking would be more granular but adds complexity not warranted for typical usage patterns.

Stats: 8 files, 269 insertions(+), 157 deletions(-)

Original prompt

Identify and suggest improvements to slow or inefficient code

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.