chore(ci): post-deploy smoke + prod env build + extended route coverage#39
Merged
Merged
Conversation
Closes three deployment-confidence gaps that the recent prod cutover (PR #37) made visible. # 1. Build with NEXT_PUBLIC_SHOW_FULL_SITE='true' in wrangler-smoke CI previously built without the env var, so the / → /home redirect codepath (production behavior) was never exercised in CI. Now matches the deploy.yml build mode. Readiness probe switched from / (now 307) to /home (always 200) so wrangler-dev startup detection still works. # 2. Extend wrangler-smoke route coverage Old coverage: POST /api/waitlist + GET /crisis (2 routes). New coverage adds 4 routes: - GET / → 307 with location: /home - GET /home → 200 + 'Mindfulness with meaning' body marker - GET /download → 200 + 'Coming soon' marker, NOT 'graphic needed' (catches if the page regresses to the pre-#36 placeholder badges) - GET /privacy/multi-state → 200 + 'Multi-State' body marker Each follows the existing /crisis assertion pattern. # 3. Post-deploy smoke against live URL (deploy.yml) Catches the failure mode CI cannot reach: DNS misconfig, custom-domain unbound, SSL broken, deploy succeeded-but-routed-wrong. After the wrangler-action deploy command succeeds: - Branch-aware URL (main → being.fyi, preview → workers.dev) - 15s sleep for Cloudflare edge propagation - Cache-busted curl on /home (200), /download (Coming soon marker), /privacy (Strict-Transport-Security header) - FAIL exits the workflow loudly so an alert fires Note on the 'Coming soon' assertion: temporary marker tied to pre-launch state. When the app launches and /download swaps to real app-store badges, update this assertion or replace with a durable marker like the H1 text. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes three deployment-confidence gaps that the recent prod cutover (PR #37) made visible. Code-correctness CI was already strong (74 unit tests + lint + typecheck + wrangler-smoke on `/api/waitlist` + `/crisis`); this PR adds the deployment-correctness layer.
Three coordinated changes
1. `ci.yml` wrangler-smoke builds with `NEXT_PUBLIC_SHOW_FULL_SITE='true'`
CI previously built without the env var, so the `/` → `/home` redirect codepath (production behavior) was never exercised. Now matches the `deploy.yml` build mode. Readiness probe switched from `/` (now returns 307) to `/home` (always 200) so wrangler-dev startup detection still works.
2. `ci.yml` wrangler-smoke extended from 2 routes → 6 routes
The `/download` assertion has a defensive NOT check for "graphic needed" — that string was in the old placeholder-badge page (pre-PR #36). If anyone regresses `/download` to the old badge content, CI catches it.
3. `deploy.yml` post-deploy smoke against live URL
Catches the failure mode CI cannot reach: DNS misconfig, custom-domain unbound, SSL broken, deploy succeeded-but-routed-wrong, deploy succeeded-but-stale.
After `wrangler-action` deploy succeeds:
Verification
CI on this PR will run the expanded wrangler-smoke job (assertions 1+2 above). After merge to preview, the deploy.yml smoke runs against `being-website-preview.palouselabs.workers.dev` (assertion 3 above). Next preview→main cutover gets the same smoke against `being.fyi` automatically.
If the smoke ever fails:
Note on durability of the "Coming soon" assertion
Temporary marker tied to pre-launch state. When the app actually launches and `/download` swaps to real app-store badges, this assertion becomes a deliberate tripwire — update or replace with a more durable marker (e.g., the H1 text) at launch time.
Out of scope (deferred from the original CI hardening proposal)
🤖 Generated with Claude Code