chore: INFRA-216 no-dev-client Maestro safety-e2e gate (e2e-sim EAS build) + corrected docs#129
Merged
MP2EZ merged 2 commits intoJun 5, 2026
Conversation
…rected docs The Maestro safety-e2e gate flaked badly because it ran against a dev-client build whose Expo dev-launcher the flows navigate by a guessed coordinate tap. Root finding: expo-dev-client is a project dependency, so even `expo run:ios --configuration Release` still ships the launcher — only a build that excludes dev-client removes it. - eas.json: add `e2e-sim` profile (developmentClient:false, simulator:true, Release) - scripts/e2e-sim-build.sh + `npm run e2e:safety:build`: build the no-dev-client sim build via EAS local and install it on the booted sim - docs/testing/e2e-maestro.md: correct the false 'Release removes the launcher' claim; document the no-dev-client target, prereqs (eas-cli/fastlane), and the known follow-up Validated: the no-dev-client build boots straight past the launcher (launcher steps WARN+skip; single warm flow run passes clean end-to-end). NOT yet reliable ≥5/5 — the slower Release build leaves the long onboarding preamble timing-fragile; the seed-state preamble-skip is the tracked INFRA-216 follow-up. The `_legal-and-onboarding.yaml` flow is intentionally unchanged here. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…6-harden-maestro-safety-e2e-release-target
MP2EZ
deleted the
chore/INFRA-216-harden-maestro-safety-e2e-release-target
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes INFRA-216 (foundation phase — reliability tail tracked in INFRA-217)
Fixes the root cause of the flaky Maestro safety-e2e gate. Finding:
expo-dev-clientis a project dependency, so bothnpm run iosAND a plainexpo run:ios --configuration Releasestill ship the Expo dev launcher — the dominant flake (navigated by a guessed-coordinate tap). Verified: every sim flow hit 0–1/5 on a dev build and on plain Release. Only a build that EXCLUDES dev-client removes the launcher.What landed
eas.json—e2e-simprofile (developmentClient:false,simulator:true, Release).scripts/e2e-sim-build.sh+npm run e2e:safety:build— EAS local no-dev-client build + install on the booted sim.docs/testing/e2e-maestro.md— corrected the false "Release removes the launcher" claim; documented the no-dev-client target, prereqs (eas-cli/fastlane), and the follow-up._bare: CLAUDE.md Known Gotchas +/b-closePhase 2.5 reconciled to the no-dev-client build.)Validated
The no-dev-client build boots straight past the launcher (
DEVELOPMENT SERVERS → WARNED/skip); a single warm q9 run passes clean end-to-end. The_legal-and-onboarding.yamlflow is intentionally unchanged.Not done (→ INFRA-217)
Consecutive ≥5/5 reliability. The slower no-dev-client Release build leaves the long onboarding preamble timing-fragile. The robust fix — seed post-onboarding state behind an
e2e-sim-profile-only env var so flows skip the preamble — is INFRA-217 (with the full state map + compliance gate).🤖 Generated with Claude Code