chore: MAINT-215 Reconcile dead API/CDN/assets URL env vars#130
Merged
Conversation
EXPO_PUBLIC_API_URL / _CDN_URL / _STATIC_ASSETS_URL were validated by
env.ts but read by no code — the only references were the schema, the
raw-env parse, and two test fixtures. They were also wrong-domain
(being.app vs the live being.fyi) and pointed at a tier that was never
built (placeholder cert pins in NetworkSecurityService; real backend is
Supabase-direct). eas.json's preview profile also injected an invalid
http://localhost:3000 value for the var.
Path (a) — Remove. No networking behavior change: the live API base
stays NetworkSecurityService's hardcoded api.being.fyi constant, now the
single source of truth. NetworkSecurityService (protected path) untouched.
- env.ts: drop the three keys from schema + readRawEnv (Env type follows)
- env.test.ts / env.mock.js: drop the three fixture entries
- eas.json: drop the dead EXPO_PUBLIC_API_URL preview injection
- .config/.env.{production,development} (out-of-band): drop the three vars
Verified: typecheck clean, env suites (30) green, precommit (377 unit) green.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
…5-reconcile-dead-url-env-vars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes MAINT-215
Removes three env vars (
EXPO_PUBLIC_API_URL/EXPO_PUBLIC_CDN_URL/EXPO_PUBLIC_STATIC_ASSETS_URL) that were validated byenv.tsbut read by no code. They were also wrong-domain (being.appvs the livebeing.fyi) and pointed at a tier that was never built —NetworkSecurityService/certificate-pinning.tscarry placeholder cert pins forapi.being.fyi, and the real backend is Supabase-direct.Path (a) — Remove (confirmed with founder; no near-term plan to stand up a custom API/CDN tier). No networking behavior change: the live API base stays
NetworkSecurityService's hardcodedapi.being.fyiconstant, now the single source of truth. The protectedcore/services/security/path is untouched, so no compliance/security review was triggered.Changes:
env.ts— drop the three keys from schema +readRawEnv(theEnvtype follows)env.test.ts/env.mock.js— drop the three fixture entrieseas.json— drop the deadEXPO_PUBLIC_API_URL: "http://localhost:3000"preview injection (invalidhttp, would fail thehttpsUrlschema).config/.env.{production,development}(out-of-band, gitignored) — drop the three varsZero-consumer confirmation (AC): grep of
app/src,app/__tests__, andeas.jsonreturns zero references post-change. Verified: typecheck clean, env suites (30) green, precommit (377 unit) green.🤖 Generated with Claude Code