Skip to content

Working code for testing apr 14 (mostly) + running ml works now!#157

Merged
imzaynb merged 32 commits intodevelfrom
testingapr14
Apr 26, 2026
Merged

Working code for testing apr 14 (mostly) + running ml works now!#157
imzaynb merged 32 commits intodevelfrom
testingapr14

Conversation

@muskaan-mittal
Copy link
Copy Markdown
Contributor

No description provided.

imzaynb and others added 30 commits March 17, 2026 14:10
FREQUENCY = 60 # times per second
BAUD_RATE = 9600
CONNECTION_NAME = "/dev/ttyACM0"
CONNECTION_NAME = "/dev/ttyACM1"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: This should be configurable via the launch file. Kinda janky that we have to change this variable in the code.

Copy link
Copy Markdown
Contributor

@imzaynb imzaynb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me tho see if you can revert the changes on the file I suggested. Thanks!!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you able to revert the changes on this file?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: look into the get_time_of_day thing that I had to remove from here, kinda sus ngl...

Copy link
Copy Markdown
Contributor

@imzaynb imzaynb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like nothing has changed since the last time that I saw this code. I feel kind of sussed out that some of my localization changes are also on this branch, but so long as it has been compiling for you then we can just move forward with the merge.

I'll be merging in my localization branch in the next couple of weeks. Just need to do some finishing touches.

@imzaynb imzaynb merged commit 8882d69 into devel Apr 26, 2026
2 checks passed
@imzaynb imzaynb deleted the testingapr14 branch April 26, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants