Skip to content

Conversation

@Dreary
Copy link
Contributor

@Dreary Dreary commented Jan 20, 2026

Moved the initialization of triggers and portals to occur after player spawn points are set up

Summary by CodeRabbit

  • Bug Fixes
    • Improved field initialization sequence to ensure triggers and portals are properly registered during map loading.
    • Enhanced trigger update handling during initialization for better game state consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

Moved the initialization of triggers and portals to occur after player spawn points are set up
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2026

Walkthrough

The FieldManager initialization flow was reordered to process triggers and portals after player spawn points are established. Additionally, a new update step for all FieldTrigger instances was introduced during initialization, while other systems maintain their existing logic.

Changes

Cohort / File(s) Summary
FieldManager Initialization Reordering
Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.cs
Moved TriggerModels and Portals initialization to occur after player spawn point setup. Added trigger.Update(FieldTick) call to update all FieldTrigger instances during Init. Maintained existing initialization of BreakableActors, Liftables, Interacts, and NPC/SpawnPoint systems with revised ordering.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • Zintixx

Poem

🐰 Initialization hops in a new order,
Triggers wait for spawns to cross the border,
Updates bloom when FieldTick appears,
A careful dance that calms our fears!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: reordering trigger and portal initialization in FieldManager, which is the primary modification described in both the PR objectives and raw summary.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AngeloTadeucci AngeloTadeucci merged commit 303470b into MS2Community:master Jan 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants