Fix: Spawn Points with no IDs

[Zintixx]

Summary by CodeRabbit

Release Notes

• Refactor
  • Optimized the player spawn point management system with improved internal architecture for storing and retrieving spawn locations across game fields. This update enhances spawn point initialization and handling, resulting in better performance and stability during gameplay.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[AngeloTadeucci]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

📝 Walkthrough

Walkthrough

This change refactors player spawn point storage from dictionary-based lookup (keyed by spawn ID) to list-based collection. It introduces an explicit Id property on FieldPlayerSpawnPoint and adds a new accessor method to retrieve all spawn points, removing the previous per-ID retrieval pattern throughout the codebase.

Changes

Cohort / File(s)	Summary
Data Model Updates Maple2.Model/Metadata/MapEntityMetadata.cs, Maple2.Database/Storage/Metadata/MapEntityStorage.cs	Changed PlayerSpawns storage from Dictionary<int, SpawnPointPC> to List<SpawnPointPC>. Updated initialization and append logic accordingly.
Field Entity Enhancements Maple2.Server.Game/Model/Field/Entity/FieldPlayerSpawnPoint.cs	Added new init-only Id property and extended constructor to accept id parameter.
FieldManager Spawn Initialization Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.cs	Refactored spawn initialization from per-ID lookup to per-fieldId logic with duplicate handling. Added GetPlayerSpawns() accessor method. Updated FieldPlayerSpawnPoint constructor calls with new fieldId parameter.
Command Layer Updates Maple2.Server.Game/Commands/FieldCommand.cs	Replaced per-ID spawn point retrieval with new Field.GetPlayerSpawns() method. Simplified spawn information access pattern.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 From dictionaries we hop away,
To lists that organize the day,
Each spawn point holds its shiny Id,
A cleaner path for Field to bid!
Thump-thump goes the refactor's drum! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly addresses the main objective of the PR—fixing spawn points with no IDs—and accurately reflects the core changes made across all modified files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.