Emit standard prometheus event on all 429 errors#2164
Merged
Conversation
alastair
force-pushed
the
429-events
branch
2 times, most recently
from
July 20, 2026 14:21
71b07cd to
32412c1
Compare
Instead of a search-specific event, have a general counter which can enumerate the different types of error message. This allows us to create alerts or graphs on a single type of rate limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I previously added a counter which allowed us to track search requests that were throttled due to bad requests. However we have other flows which send a 429 status too, so it'd be nice to be able to track all of them