Conversation
…Begin button is always reachable Co-authored-by: Maangled <108793241+Maangled@users.noreply.github.com> Agent-Logs-Url: https://github.com/Maangled/ferros/sessions/0f362126-9cbe-4eb8-8d77-3502a52ea880
Copilot
AI
changed the title
[WIP] Fix regression for Stage 0 Begin button visibility
fix: Stage 0 Begin button unreachable due to scroll gating clipping content below fold
Mar 21, 2026
This was referenced Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
body.scroll-gated { overflow: hidden; height: 100vh }(introduced in PR #24) traps the entire page at viewport height — if Stage 0 content (hero + android + featured profiles + assist levels) exceeds the viewport, the Begin button is silently clipped with no scroll path to reach it.Fix
Keep body locked, but let
#stage-0scroll internally:unlockScroll()firesunlockScroll()call sites verified correct: Begin, Skip/dismiss featured profiles, close alias gallery, close profile gallery, fork profileOriginal prompt
Goal
Fix the regression where the Stage 0 Begin button is not visible / not reachable, and ensure the Stage 0 onboarding remains gated without trapping the user.
The user reports: after pulling latest (after merging PRs #22, #23, #24 on 2026-03-21), they cannot get past the Begin button because it never shows up.
This likely stems from the scroll gating introduced in PR #24 (
body.scroll-gated { overflow: hidden; height: 100vh }) clipping content below the fold.Repo / file
Maangled/ferrosdocs/personal-profile.htmlHard constraints (from docs/AGENT_GUIDE.md)
file://protocolhashData()semantics or remove djb2 fallbacksaveProfile()Requirements
1) Make Begin reachable in Stage 0
Preferred approach:
body.scroll-gated { overflow: hidden; }max-height: 100vh; overflow-y: auto;so users can reach Begin.2) Ensure gating can be unlocked reliably
unlockScroll()should be triggered when the user:unlockScroll().3) Do not break returning user behavior
4) Add a minimal self-check note (dev comment)
Acceptance criteria
file://).Nice-to-have (optional if time)
The following is the prior conversation context from the user's chat exploration (may be truncated):
Assistant: Good call — that's a lot for one agent session, especially on a 163KB single-file HTML prototype. PR #21 is already in-flight and will likely timeout trying to do everything at once.
Here's how I'd split it into 3 focused PRs that can each finish within the hour:
PR 1 — Quick fixes + banner + recovery placeholder (items 1, 6, 7)
Smallest scope, least risk, clears the ground for the other two.
PR 2 — Hero experience + achievement animations (items 2, 3)
Focused on the top-of-page experience only — no profile/gallery changes.
PR 3 — Featured profiles revamp + onboarding gating (items 4, 5)
The heaviest change — profiles section rework + scroll gating.
Want me to go ahead and kick off PR 1 now (it's the quickest win and should finish well within the hour)? Then we can queue up PR 2 and PR 3 sequentially — or in parallel if PR 1 merges fast enough to avoid conflicts.
Also — do you want to let PR #21 keep running to see what it produces, or close it and start fresh with...
This pull request was created from Copilot chat.
⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.