Added support for specifing server url in constructor#4
Open
Utkarsh-vishnoi wants to merge 1 commit into
Open
Conversation
MacroYau
requested changes
May 3, 2018
| * @param API The address of the custom thingspeak server API. | ||
| */ | ||
| public ThingSpeakChannel(long channelId, String readApiKey, @Nullable URL API) { | ||
| THINGSPEAK_API = API.toString(); |
Owner
There was a problem hiding this comment.
You can simply check if the api parameter is null. If yes, set the Retrofit endpoint to the default one, otherwise use the custom parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have created two more constructors which now can take an optional argument, one can set THINGSPEAK_API url by passing it as a string to the last argument.
Note:- The URL to be passed must be of data-type
java.net.URLwhich is later passed into string.