store real client IP in audit logs instead of Traefik proxy IP - #178
Merged
Conversation
added 2 commits
July 6, 2026 21:44
…in forwarded headers configuration
…ary HTTP delete in ApiHooks initialization
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Audit logs were recording the internal Traefik IP (e.g. 10.1.9.123) instead of the real client IP. Two issues combined to cause this: ASP.NET Core's forwarded headers middleware only trusts loopback proxies by default, so X-Forwarded-For from Traefik was silently ignored; and when the server runs on a dual-stack socket, IPv4 connections arrive as IPv4-mapped IPv6 addresses (::ffff:x.x.x.x) which were stored as-is.
Changes
How to Test
Checklist