Skip to content

fix: enforce evidence-backed DP-5 escalation - #103

Merged
MageByte-Zero merged 2 commits into
MageByte-Zero:mainfrom
jack-lrx:codex/fix-dp5-hard-gate
Aug 7, 2026
Merged

fix: enforce evidence-backed DP-5 escalation#103
MageByte-Zero merged 2 commits into
MageByte-Zero:mainfrom
jack-lrx:codex/fix-dp5-hard-gate

Conversation

@jack-lrx

@jack-lrx jack-lrx commented Aug 6, 2026

Copy link
Copy Markdown

Summary

  • add a guarded ssf debug path for recording failed fixes and confirming DP-5
  • require three distinct, current, evidence-backed debugging attempts before escalation
  • keep Wave Review repair failures separate from debugging attempts
  • block generic ssf state set writes to protected dp_5_* fields
  • mark legacy DP-5 state without a valid ledger as unsupported in audit output
  • update workflow skills and documentation to use the guarded commands

Root cause

The generic state field allowlist included every dp_5_* field, while the bug-investigator instructions told agents to write DP-5 through ssf state set. Neither path checked debugging state, attempt count, evidence, the current execution plan, or explicit confirmation. Audit then treated any non-empty DP-5 result as recorded.

Implementation

The new debugging-attempt ledger is bound to the current artifact, contract, and execution-plan context. Evidence must be a physical file inside the change directory; duplicate, missing, changed, stale, or symlink-redirected evidence is rejected. ssf debug escalate ... --confirm is the only supported writer for DP-5 and requires at least three valid attempts.

Existing state files remain readable. A legacy unbacked DP-5 value is preserved but reported as unsupported, so compatibility does not silently convert it into a valid approval.

Verification

  • npm run build
  • NPM_CONFIG_CACHE=/private/tmp/spec-superflow-npm-cache npm test — 667 passed
  • npm run check-versions
  • npm run validate
  • node scripts/spec-superflow.mjs doctor
  • changed Skill validation for bug-investigator and build-executor
  • git diff --check

Fixes #102

@MageByte-Zero
MageByte-Zero marked this pull request as ready for review August 7, 2026 14:43
@MageByte-Zero
MageByte-Zero merged commit 5d745d1 into MageByte-Zero:main Aug 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: DP-5 can be persisted without three failed fix attempts

2 participants