fix: enforce evidence-backed DP-5 escalation - #103
Merged
MageByte-Zero merged 2 commits intoAug 7, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ssf debugpath for recording failed fixes and confirming DP-5ssf state setwrites to protecteddp_5_*fieldsRoot cause
The generic state field allowlist included every
dp_5_*field, while the bug-investigator instructions told agents to write DP-5 throughssf state set. Neither path checked debugging state, attempt count, evidence, the current execution plan, or explicit confirmation. Audit then treated any non-empty DP-5 result as recorded.Implementation
The new debugging-attempt ledger is bound to the current artifact, contract, and execution-plan context. Evidence must be a physical file inside the change directory; duplicate, missing, changed, stale, or symlink-redirected evidence is rejected.
ssf debug escalate ... --confirmis the only supported writer for DP-5 and requires at least three valid attempts.Existing state files remain readable. A legacy unbacked DP-5 value is preserved but reported as
unsupported, so compatibility does not silently convert it into a valid approval.Verification
npm run buildNPM_CONFIG_CACHE=/private/tmp/spec-superflow-npm-cache npm test— 667 passednpm run check-versionsnpm run validatenode scripts/spec-superflow.mjs doctorbug-investigatorandbuild-executorgit diff --checkFixes #102