[develop] refactor bullet point spacing#188
Conversation
4c6ca4b to
ff1d9f4
Compare
|
Bug fixed. I also introduced a new layer in the text layout engine: clauses. Now, wrapping separates lines, soft breaks separate clauses, hard breaks separate paragraphs, and line breaks separate blocks. Clauses use Margins used to work at the paragraph level (wherever the tag was in the paragraph, the margins would be applied to the paragraph as a whole. If multiple different margins were in the same paragraph, they would just be summed). I have moved them to the clause level. |
4e79e9e to
e45e218
Compare
e45e218 to
62aa267
Compare
|
we should probably auto-add the s into modals? keep it working like live and idk that we need bigger-than-hard-linebreak-modal-breaks |
|
I don't understand what you mean but sure go ahead |
|
currently hard line breaks inside a bulleted list are forced into soft-line tags (i think github ate the code tag before). this version isn't, so if you don't manually soft-break you get the 1.2 line height plus the additional margin, instead of 0.9 line height line you get on live, or the 0.9 plus margin that this PR was partially made to achieve. |
|
I see, yeah probably force soft breaks then, but this has to be done from the game script, not exe. Other games might want to be able to do this distinction. |
|
ye, just wanted to clear that before pushing changes |
change hard line breaks before a bullet into soft-lines
|
k this should be good whenever you're ready to merge it |
this file will get deleted by another pr so don't change it or it will cause conflicts
we'll be reinstating at least a shell of them for the update cards scripts won't we |
|
if you want to do that work then fine, but I'm not sure it's worth it for seldom used templates like these |
|
i have about 60 set files using that template I'll def spend a few minutes on an update script over the time to manual convert all of those lmao |
looks like there's a bug in the exe that I need to address before this can work correctly