Skip to content

[develop] transformation module#192

Open
G-e-n-e-v-e-n-s-i-S wants to merge 15 commits into
MagicSetEditorPacks:developfrom
G-e-n-e-v-e-n-s-i-S:transformation-module
Open

[develop] transformation module#192
G-e-n-e-v-e-n-s-i-S wants to merge 15 commits into
MagicSetEditorPacks:developfrom
G-e-n-e-v-e-n-s-i-S:transformation-module

Conversation

@G-e-n-e-v-e-n-s-i-S
Copy link
Copy Markdown
Collaborator

No description provided.

@G-e-n-e-v-e-n-s-i-S
Copy link
Copy Markdown
Collaborator Author

Here is my idea for the transform module.

I have broken down the symbols into three parts: background, rim and icon:
3parts

that way each part can be customized separately by the user. This allows for example to make the colored versions that the "sparker" had, but for all the symbols.

It also allows me to make variants for the showcase frames rather easily. I have implemented it here for the avatar elemental frame, the ixalan caverns frame, and the bloomburrow woodland frame. All I need to do is create one image for the background, and one image for the texture of the rim and symbol:
assets

possibly with color variants if needed. The color variants are fed through the blending code so they blend with the card color that is behind them.

I probably as always made things way more complicated than they need to.

@G-e-n-e-v-e-n-s-i-S G-e-n-e-v-e-n-s-i-S marked this pull request as ready for review April 10, 2026 04:37
@G-e-n-e-v-e-n-s-i-S G-e-n-e-v-e-n-s-i-S force-pushed the transformation-module branch 2 times, most recently from f318ca5 to 740cf99 Compare May 10, 2026 07:42
coming from a bug in the dimensions_of function: it uses the set default style instead of the card style (really it shouldn't use any style at all but that gives an error, need to investigate...)
@CajunAvenger
Copy link
Copy Markdown
Collaborator

CajunAvenger commented May 11, 2026

Right-handed transformation symbol mirrors the symbol icon, which i think is incorrect. we don't technically have any canon examples that aren't symmetric already but imo it shouldn't do that.

i kinda wish the require_exclusive_choice list in transform_symbol_script was cleaner but there's not really a "one source of truth" version we can do, and we're proobably not gonna need to make the list longer. (also is choices a new parameter, that doesn't seem to be on the docs)

looks like this has custom symbols just using the old system, i'm gonna take a stab at letting them be used in the new thing, either a style option or exists_in_package check to see if the icon/shape folder is there

@CajunAvenger
Copy link
Copy Markdown
Collaborator

the GIMP script just fails without any acknowledgement if it gets an image that's not the right size, if that's something that's fixable in there. otherwise i'm adjusting the readme instructions to note this.

i'm setting the mainframe-extras folder as /shape instead of /icon/shape since the plugin only makes /shape

* transform_symbol_image now checks if the selected custom symbol has a shape/ folder version and uses that instead if it exists
* added weather.png as an example for this.
* touched up the GIMP plugin instructions and added more for using custom ones.
put back Click OK
move the "you can save more images before you run the script" ahead of "run the script"
@G-e-n-e-v-e-n-s-i-S
Copy link
Copy Markdown
Collaborator Author

sure, I'll make it skip images that are not of the correct dimensions and issue a warning

@CajunAvenger
Copy link
Copy Markdown
Collaborator

shuffled is_mirrored to is_right, added is_mirrored as a way to flip the icon if you wanna

currently no way to do that in the field, just a script that the style can edit, idk if you wanna put that in the options or just leave it like that

if the work's already been done, doesn't hurt to add the option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants