Skip to content

[develop] Refactor emblem frames#200

Open
G-e-n-e-v-e-n-s-i-S wants to merge 5 commits into
MagicSetEditorPacks:developfrom
G-e-n-e-v-e-n-s-i-S:emblem-refactor
Open

[develop] Refactor emblem frames#200
G-e-n-e-v-e-n-s-i-S wants to merge 5 commits into
MagicSetEditorPacks:developfrom
G-e-n-e-v-e-n-s-i-S:emblem-refactor

Conversation

@G-e-n-e-v-e-n-s-i-S
Copy link
Copy Markdown
Collaborator

Combine all emblem frames into one, except for the oldest one.

@G-e-n-e-v-e-n-s-i-S G-e-n-e-v-e-n-s-i-S changed the title Refactor emblem frames [develop] Refactor emblem frames Apr 26, 2026
@G-e-n-e-v-e-n-s-i-S G-e-n-e-v-e-n-s-i-S changed the base branch from main to develop May 9, 2026 19:36
@CajunAvenger
Copy link
Copy Markdown
Collaborator

CajunAvenger commented May 14, 2026

two more wibbles in update cards script

  1. new_card doesn't accept images, so you can't currently do things like set card.image_2 as a new card's card.image. import_image("internal file name") doesn't seem to work, and we don't have a way to grab the file name anyway. possibly the line is letting import_image take an image in place of a path?

  2. setting styling_data of type "package choice" prompts the error: Could not set current working directory (error 161: The specified path is invalid.)

(also clear for rebasing)

@G-e-n-e-v-e-n-s-i-S
Copy link
Copy Markdown
Collaborator Author

pushed a change on develop to address these two problems. you can safely rebase.

import_image() should now accept images created with scripts, so you can do stuff like:
new_card([image_2: import_image(saturate(card.image, amount:1))])

as for the package choice problem, it seems to go away if you don't put a leading "/". I wrote some code to strip it automatically, but this may be a hack and the problem may resurface later.

@G-e-n-e-v-e-n-s-i-S
Copy link
Copy Markdown
Collaborator Author

ok the package choice fix hadn't actually gone through cause I'm a potato but it should be good now

@CajunAvenger
Copy link
Copy Markdown
Collaborator

all good, i haven't had a chance to rebase yet anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants