Return success when position==len; cargo fmt#1
Open
kromych wants to merge 2 commits intoMagnetForensics:mainfrom
Open
Return success when position==len; cargo fmt#1kromych wants to merge 2 commits intoMagnetForensics:mainfrom
position==len; cargo fmt#1kromych wants to merge 2 commits intoMagnetForensics:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the awesome crate :)
I have run into a case where the crate couldn't decompress a page. The code has been updated to follow
[MS-XCA] - v20210625, 2.4.4where the algorithm returns success shouldposition==len:The contents of the decompressed page have been validated against the raw memory dump.
Additionally, cargo fmt + pedantic was run on the code.
Thanks again for the crate!