Switch to using pin change interrupts#5
Open
toroidal-code wants to merge 1 commit into
Open
Conversation
toroidal-code
force-pushed
the
master
branch
from
86fff39 to
e9941ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having problems with intermittent flickering of segments of the display, and rewrote it to use Pin Change Interrupts rather than constant polling of the analog mux. It is now very responsive and stable, based on my testing.
There's a bunch of dead code that can be cleaned up as a result of this (and just cleanup in general, such as the removal of elapsedMillis and its library), but I thought that could be left for another PR.
This probably needs to be tested on another uBraids, as I've modded mine to use hardware SPI for the faster framerate/update speed.