Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions apps/mail/app/(routes)/settings/privacy/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ import { useTRPC } from '@/providers/query-provider';
import { useMutation } from '@tanstack/react-query';
// import { saveUserSettings } from '@/actions/settings';
import { useSettings } from '@/hooks/use-settings';
import { Button } from '@/components/ui/button';
import { Switch } from '@/components/ui/switch';
import { Button } from '@/components/ui/button';
import { useState, useEffect } from 'react';
import { m } from '@/paraglide/messages';
import { useForm } from 'react-hook-form';
import { m } from '@/paraglide/messages';
import { XIcon } from 'lucide-react';
import { toast } from 'sonner';
import * as z from 'zod';
Expand All @@ -32,17 +32,16 @@ export default function PrivacyPage() {

const form = useForm<z.infer<typeof userSettingsSchema>>({
resolver: zodResolver(userSettingsSchema),
defaultValues: {
externalImages: true,
trustedSenders: [],
},
});

const externalImages = form.watch('externalImages');

const externalImages = data?.settings.externalImages;
useEffect(() => {
if (data) {
form.reset(data.settings);
form.reset({
...data.settings,
trustedSenders: data.settings.trustedSenders,
externalImages: !!data.settings.externalImages,
});
}
}, [form, data]);

Expand Down Expand Up @@ -87,10 +86,10 @@ export default function PrivacyPage() {
<FormItem className="bg-popover flex w-full flex-row items-center justify-between rounded-lg border p-4 md:w-auto">
<div className="space-y-0.5">
<FormLabel className="text-base">
{m['pages.settings.privacy.externalImages']()}
{m['pages.settings.privacy.externalImages']()}
</FormLabel>
<FormDescription>
{m['pages.settings.privacy.externalImagesDescription']()}
{m['pages.settings.privacy.externalImagesDescription']()}
</FormDescription>
</div>
<FormControl className="ml-4">
Expand All @@ -107,10 +106,10 @@ export default function PrivacyPage() {
<FormItem className="bg-popover flex w-full flex-col rounded-lg border p-4">
<div className="space-y-0.5">
<FormLabel className="text-base">
{m['pages.settings.privacy.trustedSenders']()}
{m['pages.settings.privacy.trustedSenders']()}
</FormLabel>
<FormDescription>
{m['pages.settings.privacy.trustedSendersDescription']()}
{m['pages.settings.privacy.trustedSendersDescription']()}
</FormDescription>
</div>
<ScrollArea className="flex max-h-32 flex-col pr-3">
Expand Down
206 changes: 206 additions & 0 deletions apps/mail/components/mail/mail-content.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,206 @@
import { useMutation, useQuery, useQueryClient } from '@tanstack/react-query';
import { useEffect, useMemo, useRef, useState, useCallback } from 'react';
import { defaultUserSettings } from '@zero/server/schemas';
import { fixNonReadableColors } from '@/lib/email-utils';
import { useTRPC } from '@/providers/query-provider';
import { getBrowserTimezone } from '@/lib/timezones';
import { useSettings } from '@/hooks/use-settings';
import { m } from '@/paraglide/messages';
import { useTheme } from 'next-themes';
import { cn } from '@/lib/utils';
import { toast } from 'sonner';

interface MailContentProps {
id: string;
html: string;
senderEmail: string;
}

export function MailContent({ id, html, senderEmail }: MailContentProps) {
const { data, refetch } = useSettings();
const queryClient = useQueryClient();
const isTrustedSender = useMemo(
() => data?.settings?.externalImages || data?.settings?.trustedSenders?.includes(senderEmail),
[data?.settings, senderEmail],
);
const [cspViolation, setCspViolation] = useState(false);
const [temporaryImagesEnabled, setTemporaryImagesEnabled] = useState(false);
const hostRef = useRef<HTMLDivElement>(null);
const shadowRootRef = useRef<ShadowRoot | null>(null);
const { resolvedTheme } = useTheme();
const trpc = useTRPC();

const { mutateAsync: saveUserSettings } = useMutation({
...trpc.settings.save.mutationOptions(),
onSuccess: () => {
queryClient.invalidateQueries({ queryKey: ['settings'] });
},
});

const { mutateAsync: trustSender } = useMutation({
mutationFn: async () => {
const existingSettings = data?.settings ?? {
...defaultUserSettings,
timezone: getBrowserTimezone(),
};
Comment on lines +42 to +45
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Race condition possible between reading existing settings and saving. Consider using optimistic updates or locking mechanism


const { success } = await saveUserSettings({
...existingSettings,
trustedSenders: data?.settings?.trustedSenders
? data.settings.trustedSenders.concat(senderEmail)
: [senderEmail],
});

if (!success) {
throw new Error('Failed to trust sender');
}
},
onSuccess: () => {
refetch();
},
onError: () => {
toast.error('Failed to trust sender');
},
});

const { mutateAsync: processEmailContent } = useMutation(
trpc.mail.processEmailContent.mutationOptions(),
);

const { data: processedData } = useQuery({
queryKey: ['email-content', id, isTrustedSender || temporaryImagesEnabled, resolvedTheme],
queryFn: async () => {
const result = await processEmailContent({
html,
shouldLoadImages: isTrustedSender || temporaryImagesEnabled,
theme: (resolvedTheme as 'light' | 'dark') || 'light',
});

return {
html: result.processedHtml,
hasBlockedImages: result.hasBlockedImages,
};
},
staleTime: 30 * 60 * 1000,
gcTime: 60 * 60 * 1000,
refetchOnWindowFocus: false,
refetchOnMount: false,
});

useEffect(() => {
if (processedData) {
if (processedData.hasBlockedImages) {
setCspViolation(true);
}
}
}, [processedData]);

useEffect(() => {
if (!hostRef.current || shadowRootRef.current) return;

shadowRootRef.current = hostRef.current.attachShadow({ mode: 'open' });
}, []);

useEffect(() => {
if (!shadowRootRef.current || !processedData) return;

shadowRootRef.current.innerHTML = processedData.html;
}, [processedData]);

useEffect(() => {
if (!shadowRootRef.current) return;

const root = shadowRootRef.current;

const applyFix: () => void = () => {
const topLevelEls = Array.from(root.children) as HTMLElement[];
topLevelEls.forEach((el) => {
try {
fixNonReadableColors(el, {
defaultBackground: resolvedTheme === 'dark' ? 'rgb(10,10,10)' : '#ffffff',
});
} catch (err) {
console.error('Failed to fix colors in email content:', err);
}
});
};

requestAnimationFrame(applyFix);
}, [processedData, resolvedTheme]);

useEffect(() => {
if (isTrustedSender || temporaryImagesEnabled) {
setCspViolation(false);
}
}, [isTrustedSender, temporaryImagesEnabled]);

const handleImageError = useCallback(
(e: Event) => {
const target = e.target as HTMLImageElement;
if (target.tagName === 'IMG') {
if (!(isTrustedSender || temporaryImagesEnabled)) {
setCspViolation(true);
}
target.style.display = 'none';
}
},
[isTrustedSender, temporaryImagesEnabled],
);

useEffect(() => {
if (!shadowRootRef.current) return;

shadowRootRef.current.addEventListener('error', handleImageError, true);

const handleClick = (e: Event) => {
const target = e.target as HTMLElement;
if (target.tagName === 'A') {
e.preventDefault();
const href = target.getAttribute('href');
if (href && (href.startsWith('http://') || href.startsWith('https://'))) {
window.open(href, '_blank', 'noopener,noreferrer');
} else if (href && href.startsWith('mailto:')) {
window.location.href = href;
}
}
};

shadowRootRef.current.addEventListener('click', handleClick);

return () => {
shadowRootRef.current?.removeEventListener('error', handleImageError, true);
shadowRootRef.current?.removeEventListener('click', handleClick);
};
}, [handleImageError, processedData]);

return (
<>
{cspViolation && !isTrustedSender && !data?.settings?.externalImages && (
<div className="flex items-center justify-start bg-amber-600/20 px-2 py-1 text-sm text-amber-600">
<p>{m['common.actions.hiddenImagesWarning']()}</p>
<button
onClick={() => setTemporaryImagesEnabled(!temporaryImagesEnabled)}
className="ml-2 cursor-pointer underline"
>
{temporaryImagesEnabled
? m['common.actions.disableImages']()
: m['common.actions.showImages']()}
</button>
<button
onClick={async () => {
try {
await trustSender();
} catch (error) {
console.error('Error trusting sender:', error);
}
}}
className="ml-2 cursor-pointer underline"
>
{m['common.actions.trustSender']()}
</button>
</div>
)}
<div ref={hostRef} className={cn('mail-content w-full flex-1 overflow-hidden')} />
</>
);
}
10 changes: 7 additions & 3 deletions apps/mail/components/mail/mail-display.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ import { Markdown } from '@react-email/components';
import { useSummary } from '@/hooks/use-summary';
import { TextShimmer } from '../ui/text-shimmer';
import { RenderLabels } from './render-labels';
import { MailIframe } from './mail-iframe';
import { MailContent } from './mail-content';
import { m } from '@/paraglide/messages';
import { useParams } from 'react-router';
import { FileText } from 'lucide-react';
Expand Down Expand Up @@ -1205,7 +1205,7 @@ const MailDisplay = ({ emailData, index, totalEmails, demo, threadAttachments }:
<!-- Email Body -->
<div class="email-body">
<div class="email-content">
${escapeHtml(emailData.decodedBody) || '<p><em>No email content available</em></p>'}
${escapeHtml(emailData?.decodedBody || '') || '<p><em>No email content available</em></p>'}
</div>
</div>

Expand Down Expand Up @@ -1768,7 +1768,11 @@ const MailDisplay = ({ emailData, index, totalEmails, demo, threadAttachments }:
<div className="h-fit w-full p-0">
{/* mail main body */}
{emailData?.decodedBody ? (
<MailIframe html={emailData?.decodedBody} senderEmail={emailData.sender.email} />
<MailContent
id={emailData.id}
html={emailData?.decodedBody}
senderEmail={emailData.sender.email}
/>
) : null}
{/* mail attachments */}
{emailData?.attachments && emailData?.attachments.length > 0 ? (
Expand Down
Loading