fix: mobile-friendly landing hero + nested-<p> hydration fix#89
Merged
Conversation
…rror The Introduction hero forced aspect-ratio: 1600/915 on every viewport, which collapsed into a short, wide letterbox on phones with gold text floating over a busy photo. Add a max-width: 768px block that drops the fixed ratio, fills the panel with the art under a stronger scrim, scales the title responsively, and stacks the CTA buttons full-width. Desktop is unchanged. Also collapse the intro-tagline-subtitle onto a single line so MDX stops wrapping it in its own <p>, which produced an invalid <p>-in-<p> and a React hydration error. Applied to the current (next) docs and the 3.14.0 snapshot.
enoch85
force-pushed
the
fix/mobile-friendly-docs
branch
from
374955e to
383880e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Introduction landing page on mobile and resolves a hydration error.
aspect-ratio: 1600/915on all viewports, producing a cramped letterbox on phones. Amax-width: 768pxrule insrc/css/custom.cssnow lets the panel size to its content, strengthens the background scrim for legibility, scales the title responsively, and stacks the call-to-action buttons. Desktop is unaffected.intro-tagline-subtitletext was wrapped by MDX in a nested<p>, causing an invalid<p>-in-<p>and a React hydration error. Collapsing it to a single line resolves this, applied to the current docs and the 3.14.0 snapshot.Verification
npm run buildandnpm run format:checkpass/