Fixing Asset Lib filter search param encoding#157
Open
nebspacefarer wants to merge 2 commits intoMakovWait:mainfrom
Open
Fixing Asset Lib filter search param encoding#157nebspacefarer wants to merge 2 commits intoMakovWait:mainfrom
nebspacefarer wants to merge 2 commits intoMakovWait:mainfrom
Conversation
Contributor
|
Shouldn't it strip edges before encoding? Otherwise it would encode a space at the end. Not super important probably though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit aims to fix #155 by encoding spaces, fixing searches filter containing spaces.
Implementation is simple enough, replacing all space characters by the encoded version %20 with the built-in method, fixing the issue.