This repository was archived by the owner on Nov 11, 2023. It is now read-only.
Allow anonymous login#25
Open
SoftWyer wants to merge 5 commits intoMaliffic:masterfrom
SoftWyer:feature/allow-anonymous-login
Open
Allow anonymous login#25SoftWyer wants to merge 5 commits intoMaliffic:masterfrom SoftWyer:feature/allow-anonymous-login
SoftWyer wants to merge 5 commits intoMaliffic:masterfrom
SoftWyer:feature/allow-anonymous-login
Conversation
Author
|
Got this working with an iOS build. If you have trouble, then note the comments in this thread for the Facebook flutter plugin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a new button for guest login (firebase's Anonymous login).
Fairly straightforward except the button image is an Icon, rather than an asset. Icons will honour the theme sizing but I've had to hardcode a size to match the assets. Incidentally, I'm not sure that the 2x and 3x assets are handled correctly unless there is some magic going on within the theme, if so, then the hardcoding will probably be broken.
This PR also includes the dependency uplift in #23 (which worked fine on Android, yet to test on iOS but there's an initial build error which could be anything and nothing as per usual with iOS :-/ )