Open
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
|
![kiloconnect[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| * @brief A simple struct to represent a aligned storage for a cache line. | ||
| */ | ||
| struct alignas(64) CacheLine { | ||
| std::array<std::byte, 64> data; |
There was a problem hiding this comment.
WARNING: Missing header for std::array
include/pixie/cache_line.h uses std::array but the header does not include <array>, which can break builds depending on include order. Add the missing include in this header so it is self-contained.
| uint64_t pos = rng() % n; | ||
| benchmark::DoNotOptimize(bv.rank(pos)); | ||
| std::mt19937_64 rng(42); | ||
| if (std::popcount(n) == 1) { |
There was a problem hiding this comment.
WARNING: Missing <bit> include for std::popcount
std::popcount is declared in <bit>. Relying on transitive includes can break builds on different standard library versions, so it should be included explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.