fix: explicitly block stored procedure SQL calls#96
Open
palakjaiswal16 wants to merge 1 commit into
Open
Conversation
Owner
|
This PR currently has merge conflicts with the base branch. Please resolve them so we can proceed with merging. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Explicitly blocks stored procedure SQL calls in the read-only query guard so
EXEC,EXECUTE, andCALLare rejected intentionally instead of only being blocked incidentally.Type of Change
What Was Changed
isReadOnlySqlQueryinto a smallquery-safetymodule so it can be tested directly.exec,execute, andcallto the blocked SQL keyword list.How to Test
npm installnpm test -- --runnpm run lintChecklist
npm run lintpasses (no TypeScript errors)Screenshots (if UI change)
Not applicable. This is a backend/query safety change.
Related Issues / PRs
Closes #74