feat: upgrade nginx version and add downloads configuration(MAPCO-10121)#72
Merged
Conversation
CL-SHLOMIKONCHA
requested changes
Mar 19, 2026
CL-SHLOMIKONCHA
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Helm chart and NGINX configuration to improve modularity, upgrade dependencies, and enhance observability. The changes separate the downloads server configuration, modernize the NGINX image and dependencies, and introduce OpenTelemetry tracing support.
NGINX and Helm Chart Improvements:
nginxHelm dependency to version2.1.1and changed the repository tocommon, ensuring use of the latest, standardized NGINX chart. (helm/Chart.yaml)common/nginx:v2.1.0for consistency and access to newer features. (helm/values.yaml)Configuration Refactoring and Modularity:
/downloadsserver block configuration into a dedicateddownloads.conffile, improving modularity and clarity in NGINX configuration. (helm/config/downloads.conf,helm/config/nginx.conf,helm/templates/nginx/nginx-configmap.yaml,helm/values.yaml) [1] [2] [3]downloads.conffile. (helm/values.yaml,helm/templates/nginx/nginx-configmap.yaml) [1] [2]Observability and Logging Enhancements:
helm/config/nginx.conf,helm/values.yaml) [1] [2]log_format.conffile and switching the access log to use themainformat. (helm/config/nginx.conf)Ingress and Service Configuration:
ingressClassName, support additional annotations, and provide a more flexible mapping structure. (helm/values.yaml)