feat(grafana-datasources)!: changed from tpl to secret#107
Open
CptSchnitz wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR converts datasource-library from a Helm library chart that emitted provisioning YAML via tpl/consumer templates into an application chart that directly renders a labeled Kubernetes Secret containing Grafana datasource provisioning YAML (for consumption by the Grafana k8s-sidecar). This is a breaking change in how consumers integrate the chart.
Changes:
- Render Grafana datasource provisioning as a Secret (
templates/datasources-secret.yaml) instead of requiring consumer charts to create a ConfigMap/template wrapper. - Move
team/environmentto instance-level and update postgres datasource generation logic + auth validation in templates. - Add a JSON schema for values validation and update documentation to match the new usage.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/datasource-library/values.yaml | Adds default values structure for datasources.postgres. |
| charts/datasource-library/values.schema.json | Introduces schema validation for instance-level and postgres datasource entries. |
| charts/datasource-library/templates/datasources-secret.yaml | New Secret template that wraps provisioning output for k8s-sidecar pickup. |
| charts/datasource-library/templates/_helpers.tpl | Adds helpers for required team, resolved environment, and a computed base name. |
| charts/datasource-library/templates/_datasources.tpl | Updates postgres provisioning generation and auth/SSL handling. |
| charts/datasource-library/README.md | Documents the new Secret-based integration, naming, and auth model. |
| charts/datasource-library/Chart.yaml | Updates chart metadata and changes type from library to application. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ## Values | ||
|
|
||
| ### PostgreSQL entry | ||
| Values are validated by `values.schema.json` (field types, enums, unknown-key rejection, and the `rootCertFile` requirement). Team/environment resolution and the auth-method requirement are enforced at render time. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ronenkapelian
requested changes
Jul 15, 2026
ronenkapelian
left a comment
ronenkapelian
left a comment
Contributor
There was a problem hiding this comment.
-
The name should be replaced from library to something meaningful and also update it on readme
-
out of the scope, but it will be nice to add Standard Helm/Kubernetes Labels on Secret
The upstream 'min length for ssl files' autofix dropped the closing brace of the ssl 'properties' object, producing invalid JSON. Restore it while keeping the minLength additions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
CptSchnitz
changed the title
ronenkapelian
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.