Skip to content

fix: expose delete job/task type as env vars (MAPCO-11103)#99

Merged
roicohen326 merged 2 commits into
masterfrom
feat/delete-env-vars-MAPCO-11103
Jul 14, 2026
Merged

fix: expose delete job/task type as env vars (MAPCO-11103)#99
roicohen326 merged 2 commits into
masterfrom
feat/delete-env-vars-MAPCO-11103

Conversation

@roicohen326

@roicohen326 roicohen326 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds `ingestionDeleteJobType` → `INGESTION_DELETE_JOB_TYPE` and `deleteTaskType` → `DELETE_TASK_TYPE` to `config/custom-environment-variables.json`, matching every sibling job/task type key.
  • These two config keys were added to `default.json` during the delete-layer-endpoint work (feat: add delete layer endpoint (MAPCO-118) #97) but never wired up as environment-variable overrides.
  • Adds the matching `helm/values.yaml` (`jobDefinitions.jobs.delete` / `jobDefinitions.tasks.delete`) and `helm/templates/configmap.yaml` (`INGESTION_DELETE_JOB_TYPE`, `DELETE_TASK_TYPE`) entries so a deployment can actually set them via ConfigMap.

ingestionDeleteJobType and deleteTaskType were added to default.json
during the delete-layer-endpoint work but never wired up as
environment-variable overrides, unlike every sibling job/task type key.
Adds the missing custom-environment-variables.json mapping plus the
matching Helm chart values/configmap entries so a deployment can set
them via ConfigMap like the rest.
Comment thread helm/values.yaml Outdated
Per review feedback - disambiguates from the sibling task-side
delete key.
@CL-SHLOMIKONCHA CL-SHLOMIKONCHA changed the title feat: expose delete job/task type as env vars (MAPCO-11103) fix: expose delete job/task type as env vars (MAPCO-11103) Jul 14, 2026
@roicohen326 roicohen326 merged commit d06ec42 into master Jul 14, 2026
5 checks passed
@roicohen326 roicohen326 deleted the feat/delete-env-vars-MAPCO-11103 branch July 14, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants