feat: add deletion task to job definitions and update related configu…#66
Merged
Conversation
…rations Co-authored-by: Copilot <copilot@github.com>
CL-SHLOMIKONCHA
requested changes
May 17, 2026
…lated configurations
CL-SHLOMIKONCHA
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for a new "deletion" task type throughout the codebase. The main changes involve updating configuration files, interfaces, and handlers to recognize and handle the new task type, ensuring it is integrated into the task flow and appropriately excluded where necessary.
Configuration and Task Flow Updates:
deletionas a recognized task type in configuration files, includinghelm/values.yaml,helm/templates/configmap.yaml, andconfig/custom-environment-variables.json. [1] [2] [3]tiles-deletionin thetaskFlowManager.ingestionTasksFlowinhelm/values.yaml, integrating deletion into the ingestion workflow.Interface and Handler Adjustments:
IJobDefinitionsConfiginterface insrc/common/interfaces.tsto include the newdeletiontask type.IngestionJobHandlerinsrc/tasks/handlers/ingestion/ingestionHandler.tsto add thedeletiontask type to the list of excluded types, preventing its duplication in certain scenarios.Documentation:
README.mdto document the newJOB_DEFINITIONS_TASK_DELETIONenvironment variable.