fix: ignore task notifications for aborted/expired jobs(MAPCO-11121)#70
Merged
almog8k merged 2 commits intoJul 15, 2026
Merged
Conversation
CL-SHLOMIKONCHA
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where a manually aborted ingestion update job could still reach and fail at the finalize task, with the polygon-parts processParts step erroring that the validation table doesn't exist.
Root cause: aborting a job only moves its currently-PENDING tasks to ABORTED — a task already IN_PROGRESS (e.g. a tiles-merging task mid-run) keeps running untouched, and the abort flow also deletes the layer's polygon-parts validation table. When that in-flight task later completes and notifies job-tracker, handleTaskNotification acted on it without checking the job's own status:
Fix: in TasksManager.handleTaskNotification, after fetching the job, short-circuit and log a warning if the job is already in a terminal state (ABORTED or EXPIRED) — skip both task-flow advancement and job status updates for that notification.
Changes