ci: update build and push workflow#39
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the build and push workflow by updating event triggers and restructuring jobs to leverage shared workflows.
- Changed workflow triggers to include manual dispatch and tag-based pushes.
- Introduced two separate jobs for Docker and Helm artifact builds using shared workflows.
Comments suppressed due to low confidence (1)
.github/workflows/build_and_push.yaml:3
- [nitpick] Verify that switching the trigger from 'create' to 'push' (with tags) aligns with the intended workflow behavior and update documentation if necessary to avoid confusion.
on: push: tags:
| - 'v*' | ||
|
|
||
| jobs: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
[nitpick] Consider documenting how the 'version' input will be utilized within the workflow or passed to the shared workflows to ensure future maintainers understand its role.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI workflows by configuring release-please and revamping the build and push artifacts workflow.
- Introduces a new release-please configuration and manifest file.
- Implements a new release workflow using Google’s release-please-action.
- Revamps the build and push workflow to use shared workflows for Docker and Helm with an added manual trigger.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| release-please-config.json | Adds configuration for release-please using node release type. |
| .release-please-manifest.json | Introduces manifest file for release-please versioning. |
| .github/workflows/release_please.yaml | Sets up a workflow to trigger releases on pushes to the 'master' branch. |
| .github/workflows/build_and_push.yaml | Updates the build and push workflow with new triggers and shared workflows. |
Comments suppressed due to low confidence (1)
.github/workflows/release_please.yaml:2
- [nitpick] The workflow trigger is set to 'push' events on the 'master' branch; please confirm that this is intentional, as many repositories now use 'main' as the default branch.
push:
| - 'v*' | ||
|
|
||
| jobs: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
[nitpick] Consider adding a brief comment explaining the purpose and expected input for the 'workflow_dispatch' trigger to aid users triggering the workflow manually.
Updated build-and-push workflow
Added release please workflow