Skip to content

ci: update build and push workflow#39

Open
NivGreenstein wants to merge 4 commits into
masterfrom
refactor/update-build-and-push-action
Open

ci: update build and push workflow#39
NivGreenstein wants to merge 4 commits into
masterfrom
refactor/update-build-and-push-action

Conversation

@NivGreenstein

@NivGreenstein NivGreenstein commented May 14, 2025

Copy link
Copy Markdown

Updated build-and-push workflow
Added release please workflow

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the build and push workflow by updating event triggers and restructuring jobs to leverage shared workflows.

  • Changed workflow triggers to include manual dispatch and tag-based pushes.
  • Introduced two separate jobs for Docker and Helm artifact builds using shared workflows.
Comments suppressed due to low confidence (1)

.github/workflows/build_and_push.yaml:3

  • [nitpick] Verify that switching the trigger from 'create' to 'push' (with tags) aligns with the intended workflow behavior and update documentation if necessary to avoid confusion.
on: push: tags:

- 'v*'

jobs:
workflow_dispatch:

Copilot AI May 14, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider documenting how the 'version' input will be utilized within the workflow or passed to the shared workflows to ensure future maintainers understand its role.

Copilot uses AI. Check for mistakes.
@NivGreenstein NivGreenstein changed the title refactor: update build and push workflow ci: update build and push workflow May 14, 2025
@NivGreenstein
NivGreenstein requested a review from Copilot May 14, 2025 07:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI workflows by configuring release-please and revamping the build and push artifacts workflow.

  • Introduces a new release-please configuration and manifest file.
  • Implements a new release workflow using Google’s release-please-action.
  • Revamps the build and push workflow to use shared workflows for Docker and Helm with an added manual trigger.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
release-please-config.json Adds configuration for release-please using node release type.
.release-please-manifest.json Introduces manifest file for release-please versioning.
.github/workflows/release_please.yaml Sets up a workflow to trigger releases on pushes to the 'master' branch.
.github/workflows/build_and_push.yaml Updates the build and push workflow with new triggers and shared workflows.
Comments suppressed due to low confidence (1)

.github/workflows/release_please.yaml:2

  • [nitpick] The workflow trigger is set to 'push' events on the 'master' branch; please confirm that this is intentional, as many repositories now use 'main' as the default branch.
push:

- 'v*'

jobs:
workflow_dispatch:

Copilot AI May 14, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a brief comment explaining the purpose and expected input for the 'workflow_dispatch' trigger to aid users triggering the workflow manually.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants