deps: upgrade js-logger to v5 to support alloy (MAPCO-10962)#114
Merged
Conversation
Bumps js-logger to v5 (async, named export) and schemas to the version exposing the v2 logger schema, wires up opentelemetryOptions through config and the helm chart so logs can be shipped via OTLP to Alloy.
mc-priority-queue@8.2.2 and mc-utils@3.2.0 still declare a stale js-logger@^1.0.1 peerDependency, which conflicts with the v5 bump and breaks npm ci. Both packages only reference the js-logger Logger type (never its factory function), so the peer range is stale rather than a real incompatibility. Override it to resolve against the root's installed js-logger version instead of bumping the whole raster-shared/mc-model-types major line, which is unrelated to this ticket.
CL-SHLOMIKONCHA
requested changes
Jul 12, 2026
Address review feedback: replace the ad-hoc global/env if-else helpers with a single common.openTelemetryOptions.merged definition using the existing common.tplvalues.merge pattern, and consume the merged dict in configmap.yaml. Also leave env.openTelemetryOptions.url empty, since a concrete default there would win over a global override in the merge (env is merged first).
Adds telemetry.logger.opentelemetryOptions.resourceAttributes, mapped from OPENTELEMETRY_RESOURCE_ATTRIBUTES, and threads it through the helm chart. Not yet declared in @map-colonies/schemas, but verified it validates and survives config resolution end-to-end (ajv here has no removeAdditional, and the opentelemetryOptions sub-schema has no unevaluatedProperties restriction), and js-logger's own LoggerOptions type already accepts it.
CL-SHLOMIKONCHA
approved these changes
Jul 12, 2026
CL-SHLOMIKONCHA
requested changes
Jul 13, 2026
Matches the convention already used by other services in this cluster (e.g. raster-ingestion-dev-overseer). The schemas package's declared x-env-value (OTLP_LOGGER_ENDPOINT_URL) doesn't match what's actually deployed. Per review feedback.
CL-SHLOMIKONCHA
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
@map-colonies/js-loggerto^5.0.0(async, named export) so this servicecan ship logs via OTLP to Alloy. Bumps
@map-colonies/schemasto^1.18.0for thelogger schema that adds
telemetry.logger.opentelemetryOptions, wired through configand the helm chart (disabled by default). Adds
K8S_POD_UIDto the deployment forOTel pod attribution.