This repository was archived by the owner on May 22, 2024. It is now read-only.
Open
Conversation
Contributor
Author
|
@MarcusCemes does this look fine to you? I did only test with with TypeScript / CLI. The rotate pipe should work with yaml / json fine tough. Also this:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run buildandnpm testpassesAffected core subsystem(s)
core
Description of change
Added a basic rotate pipe (https://sharp.pixelplumbing.com/api-operation#rotate) because images (from Smartphone for example) will loose rotation information due to compress. In order to fix this, a rotate will be made before which takes the EXIF data into account if no arguments are provided. (see https://stackoverflow.com/questions/48716266/sharp-image-library-rotates-image-when-resizing)
It was a copy paste from the resize pipe, but it does it's job nicely.
Eventually in the future it would be great to offer an advanced pipe, which exposes a sharp instance and allows to chain multiple sharp operations together. ;)
@MarcusCemes is this
sharp.concurrency(1);needed in each core pipe at the top? Is this used because ipp already exposes it's own concurrency?