-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
MDEV-38328: Promote getting to 10k GitHub stars in server log and client prompt #4262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6908f9e to
eb8609c
Compare
|
Failure in test buildbot/amd64-ubuntu-2204-debug-ps seems unrelated to this PR: |
|
Plug? It’s not always welcomed.1
It was recently filed at MDEV-37501. Footnotes |
Depends on the plug. Sometimes it is welcomed, like in the case of Thunderbird getting a new life once they started appealing to their users. Going past 10k stars is fine, the more the better. I think this type of request for support/visibility is a good way to appeal to users and show one easy way they can support the project. |
|
I just saw it after launching the client cli and I came over to give my star |
|
I was surprised to see this showing up in the latest LTS release, it turns out the Debian package maintainer added this as a patch to the Debian package for some reason. I expect GitHub star chasing from My First Node.js package, not a professional RDBMS. |
eb8609c to
deb13d3
Compare
|
For reference, this is what you see when launching lazygit (68k GitHub stars) for the first time:
|
deb13d3 to
632181b
Compare
It's a free software, so imo asking for help with a github star is totally appropriate. Also, it's made by professionals, but not only for professionals -- it's for everyone. |
632181b to
620585a
Compare
|
Thank you again for your pull request! After discussing it internally we have decided that we will not be taking it in at this point of time. |
|
After some more internal discussion (and MariaDB foundation management changing their mind about it) I'm re-opening the pull request. Are you still interested in working with me and Sergei (as a final reviewer) to get this in or should I take this over? |
Ask users to give MariaDB a star by having an extra line in the MariaDB
client prompt:
Welcome to the MariaDB monitor. Commands end with ; or \g.
Your MariaDB connection id is 33
Server version: 12.2.0-MariaDB-1:12.2.0 mariadb.org binary distribution
Copyright (c) 2000, 2018, Oracle, MariaDB Corporation Ab and others.
Help us reach 10k stars! Visit https://github.com/MariaDB/Server
Type 'help;' or '\h' for help. Type '\c' to clear the current input statement.
MariaDB [(none)]>
Additionally, have this extra line in server logs:
[Note] Help us reach 10k stars! Visit https://github.com/MariaDB/server
This change is done in a way that it is easy to cherry-pick to older
releases, and the text can later be changed to promote something else
once MariaDB has surpassed MySQL in GitHub stars.
Test file updated with:
nano --noconvert --nonewlines mysql-test/main/mysql-interactive.result
620585a to
944c4e2
Compare
|
I've rebased this on latest |

Description
Ask users to give MariaDB a star by having an extra line in the MariaDB client prompt:
Additionally, have this extra line in server logs:
This change is done in a way that it is easy to cherry-pick to older releases, and the text can later be changed to promote something else once MariaDB has surpassed MySQL in GitHub stars.
Release Notes
How can this PR be tested?
Basing the PR against the correct MariaDB version
mainbranch.PR quality check