MDEV-37042 innodb_undo_log_truncate=ON leads to out-of-bounds write #4555
+9
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
During undo tablespace truncation, pages with LSNs older than the tablespace creation LSN may still exist in the buffer pool and get submitted to the doublewrite buffer. When mtr_t::commit_shrink() is invoked shortly after doublewrite batch submission, this can lead to out-of-bounds write errors.
Fix:
buf_dblwr_t::flush_buffered_writes_completed() : skip doublewrite processing for pages where the page LSN is older
than the tablespace creation LSN. Such pages belong to the old tablespace before truncation and should not be written through the doublewrite buffer.