MDEV-38487: Prevent aggregate function cloning when pushing HAVING into WHERE #4560
+241
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to WHERE Problem: When building a pushable condition that can be pushed from HAVING into WHERE, the server tries to clone aggregate functions. This is not necessary because aggregate functions can not be pushed into WHERE anyway. Fix: This fix introduces a check within `Item::build_pushable_cond` to skip cloning aggregate functions. Also fixes assert failure in MDEV-38492, by adding a missing copy method for `Item_aggregate_ref`.
sanja-byelkin
force-pushed
the
bb-10.6-mdev-38487
branch
from
bba9875 to
e81936d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - MDEV-38487
Problem
When building a pushable condition that can be pushed from HAVING into WHERE, the server tries to clone aggregate functions. This is not necessary because aggregate functions can not be pushed into WHERE anyway.
Fix
This fix introduces a check within
Item::build_pushable_condto skip cloning aggregate functions.Also fixes assert failure in MDEV-38492, by adding a missing copy method for
Item_aggregate_ref.