-
Notifications
You must be signed in to change notification settings - Fork 142
Implement custom cardstack tag colors and order #2809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yihao03
wants to merge
14
commits into
MarkBind:master
Choose a base branch
from
yihao03:feat/cardstack-tag-order-colors-implementation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+901
−177
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
464e746
feat: add custom tag order and colors for CardStack component
yihao03 7698efd
Refactor and abstract code
yihao03 a2801bc
Add tests
yihao03 814f1b4
Remove redundant code in userguide
yihao03 2c8fa85
Update type and typecheck
yihao03 0626ecb
Refactor to avoid circular reference
yihao03 a718071
Merge branch 'master' into feat/cardstack-tag-order-colors-implementa…
yihao03 2ffbfb8
Update docs/userGuide/syntax/cardstacks.md
yihao03 70157a7
Merge branch 'feat/cardstack-tag-order-colors-implementation' of gith…
yihao03 f070f94
Move processCardStackAttributes from MdAttributeRenderer
yihao03 b66f99c
Update tests
yihao03 21370b4
Lint
yihao03 943bdbc
Replace html escape functions with html-entities library
yihao03 ca2b4f3
Merge branch 'master' into feat/cardstack-tag-order-colors-implementa…
yihao03 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: I wonder if it'd be better (as a reader) for the custom tag order to be above the MRQ cardstack example?
I think I'd prefer it that way but I realize that it might be subjective so if you think this is better/ok that's fine!