Skip to content

Fix bootstrap icon #2820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gerteck merged 2 commits into from
Feb 1, 2026
+3 −1
Merged

Fix bootstrap icon #2820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d90d72e
Update icon regex to allow numbers
Incogdino Feb 1, 2026
9b849cb
Add tests for bootstrap icons with numbers and dashes
Incogdino Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/lib/markdown-it/plugins/markdown-it-icons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const markdownItRegExp = require('markdown-it-regexp');

// regular expression to match the icon patterns
const ICON_REGEXP
= /:(fa[brs]|fa-brands|fa-solid|glyphicon|octicon|octiconlight|mi[forst]|bi)-([a-z-]+)~?([a-z-]+)?:/;
= /:(fa[brs]|fa-brands|fa-solid|glyphicon|octicon|octiconlight|mi[forst]|bi)-([a-z0-9-]+)~?([a-z0-9-]+)?:/;

// function to get the octicon icons
function getOcticonIcon(iconName: string) {
Expand Down
2 changes: 2 additions & 0 deletions packages/core/test/unit/lib/markdown-it/plugins/markdown-it-icons.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,8 @@ test('should render all Bootstrap icons correctly', () => {
// Basic bootstrap icons, with dashes
expect(md.renderInline(':bi-house:')).toBe('<i class="bi-house"></i>');
expect(md.renderInline(':bi-arrow-left:')).toBe('<i class="bi-arrow-left"></i>');
expect(md.renderInline(':bi-backpack2:')).toBe('<i class="bi-backpack2"></i>');
expect(md.renderInline(':bi-backpack2-fill:')).toBe('<i class="bi-backpack2-fill"></i>');
});

test('should handle multiple icons and complex scenarios', () => {
Expand Down