-
Notifications
You must be signed in to change notification settings - Fork 142
Update bootstrap version to latest 1.13.1 #2821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bootstrap version to latest 1.13.1 #2821
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2821 +/- ##
=======================================
Coverage 71.85% 71.85%
=======================================
Files 134 134
Lines 7340 7340
Branches 1524 1623 +99
=======================================
Hits 5274 5274
Misses 1938 1938
Partials 128 128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Bootstrap Icons library from version 1.11.3 to 1.13.1, adding support for 28 new icons in the latest release. The update addresses issue #2797 which requested support for the latest Bootstrap Icons, and follows up on PR #2820 which fixed support for icons with numbers in their names.
Changes:
- Updated
bootstrap-iconsdependency from^1.11.3to^1.13.1in package.json - Updated package-lock.json with new version and integrity hash
- Updated test expectation files across all 9 test site directories with the new icon definitions
Reviewed changes
Copilot reviewed 31 out of 62 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/package.json | Updated bootstrap-icons dependency version to ^1.13.1 |
| package-lock.json | Updated lock file with new version 1.13.1 and integrity hash |
| packages/cli/test/functional/*/expected/markbind/bootstrap-icons/font/bootstrap-icons.css | Updated version header and added 28 new icon CSS rules |
| packages/cli/test/functional/*/expected/markbind/bootstrap-icons/font/bootstrap-icons.scss | Updated version header and added 28 new icon SCSS definitions |
| packages/cli/test/functional/*/expected/markbind/bootstrap-icons/font/bootstrap-icons.json | Updated JSON with 28 new icon Unicode mappings |
| packages/cli/test/functional/test_site/expected/markbind/bootstrap-icons/font/bootstrap-icons.min.css | Updated minified CSS with version and new icons |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gerteck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@gerteck Each PR must have a SEMVER impact label, please remember to label the PR properly. |
What is the purpose of this pull request?
Fixes #2797
Overview of changes:
Update bootstrap icons to include the latest suite of icons
Anything you'd like to highlight/discuss:
Following up with issue #2820, icons that have numbers in their names should be resolved as well
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Update bootstrap version to v1.13.1
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):