Skip to content

Conversation

@Incogdino
Copy link
Contributor

@Incogdino Incogdino commented Feb 1, 2026

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Fixes #2797

Overview of changes:
Update bootstrap icons to include the latest suite of icons

Anything you'd like to highlight/discuss:
Following up with issue #2820, icons that have numbers in their names should be resolved as well

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Update bootstrap version to v1.13.1


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

@codecov
Copy link

codecov bot commented Feb 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.85%. Comparing base (e708005) to head (668fb21).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2821   +/-   ##
=======================================
  Coverage   71.85%   71.85%           
=======================================
  Files         134      134           
  Lines        7340     7340           
  Branches     1524     1623   +99     
=======================================
  Hits         5274     5274           
  Misses       1938     1938           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Bootstrap Icons library from version 1.11.3 to 1.13.1, adding support for 28 new icons in the latest release. The update addresses issue #2797 which requested support for the latest Bootstrap Icons, and follows up on PR #2820 which fixed support for icons with numbers in their names.

Changes:

  • Updated bootstrap-icons dependency from ^1.11.3 to ^1.13.1 in package.json
  • Updated package-lock.json with new version and integrity hash
  • Updated test expectation files across all 9 test site directories with the new icon definitions

Reviewed changes

Copilot reviewed 31 out of 62 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/core/package.json Updated bootstrap-icons dependency version to ^1.13.1
package-lock.json Updated lock file with new version 1.13.1 and integrity hash
packages/cli/test/functional/*/expected/markbind/bootstrap-icons/font/bootstrap-icons.css Updated version header and added 28 new icon CSS rules
packages/cli/test/functional/*/expected/markbind/bootstrap-icons/font/bootstrap-icons.scss Updated version header and added 28 new icon SCSS definitions
packages/cli/test/functional/*/expected/markbind/bootstrap-icons/font/bootstrap-icons.json Updated JSON with 28 new icon Unicode mappings
packages/cli/test/functional/test_site/expected/markbind/bootstrap-icons/font/bootstrap-icons.min.css Updated minified CSS with version and new icons

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@gerteck gerteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerteck gerteck merged commit c5e1fde into MarkBind:master Feb 1, 2026
16 checks passed
@github-actions
Copy link

github-actions bot commented Feb 1, 2026

@gerteck Each PR must have a SEMVER impact label, please remember to label the PR properly.

@gerteck gerteck added the r.Patch Version resolver: increment by 0.0.1 label Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r.Patch Version resolver: increment by 0.0.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for bootstrap icons

2 participants