test(coordinators): boost unit test suite coverage across all coordinators - #475
Merged
Conversation
…ators - Add comprehensive test suites for calibration, live batch, live camera session, model diagnostics, multi aquarium, progress tracking, project lifecycle, recording session, report generation, sequential processing, and single video mixin. - Expand UIStateController test suite covering OpenVINO conversion and processing mode updates. - All 648 coordinator unit tests passing cleanly.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the unit test suite for the coordinator layer, adding targeted tests for coordinator helper methods and lifecycle behaviors to improve confidence and coverage across orchestration code paths.
Changes:
- Added new coordinator-focused unit test modules covering report generation, sequential processing, recording sessions, project lifecycle, progress tracking, multi-aquarium flows, model diagnostics, live session flows, and calibration.
- Expanded
UIStateControllertests to cover OpenVINO status/device updates and UI scheduling helpers. - Introduced
_SingleVideoMixinhelper-method tests viaVideoProcessingCoordinatorto validate calibration/metadata extraction and zone persistence/setup behavior.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/coordinators/test_ui_state_coordinator.py | Extends UI state tests, including OpenVINO status/device paths and UI scheduling helpers. |
| tests/coordinators/test_single_video_mixin_helpers.py | New tests for _SingleVideoMixin helper methods via VideoProcessingCoordinator. |
| tests/coordinators/test_sequential_processing_coordinator.py | New tests for sequential multi-aquarium processing flow and output registration. |
| tests/coordinators/test_report_generation_coordinator.py | New tests for report generation orchestration and parquet summary processing branches. |
| tests/coordinators/test_recording_session_coordinator.py | New tests for recording session lifecycle, dependency validation, and external trigger handling. |
| tests/coordinators/test_project_lifecycle_coordinator.py | New tests for project open/create/close flows and project-data operations. |
| tests/coordinators/test_progress_tracking_coordinator.py | New tests for batch context handling, progress lifecycle, UI scheduling, and cancellation behavior. |
| tests/coordinators/test_multi_aquarium_coordinator.py | New tests for multi-aquarium detection, assignment, and processing-mode propagation behavior. |
| tests/coordinators/test_model_diagnostics_coordinator.py | New tests for diagnostics workflow, OpenVINO handling, and thread-path error behavior. |
| tests/coordinators/test_live_camera_session_coordinator.py | New tests for live session lifecycle, metadata publishing, and UI finalization logic. |
| tests/coordinators/test_live_batch_coordinator.py | New tests for batch session registration, persistence behavior, and unified-report triggering logic. |
| tests/coordinators/test_calibration_coordinator.py | New tests for calibration scope resolution and calibration session context behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+259
to
+260
| # State updated | ||
| # State updated |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary