fix(runtime): harden Codex, restart flow, tool previews, and restart gating

[kdegeek]

Summary

• Harden Codex/OAuth runtime behavior from the previously prepared broad branch, including macOS/Linux HOME-path handling and Codex model-cache fallback behavior.
• Harden restart/update flow and restart gating so platform restart controls are safer and better scoped.
• Normalize pending tool preview arguments so UI tool previews render more reliably while calls are in progress.
• Include related runtime/UI cleanup from the split bugfix branch, separated from the provider-expansion PR.

Validation

Previously passed before this split PR branch was prepared:

• Provider-targeted tests and OpenRouter LLM tests passed during the broad branch validation.
• bun run typecheck — PASS.
• bun run build — PASS (existing Vite chunk-size warnings only).
• git diff --check — PASS.
• Full bun run test passed during final PR-prep before the broad work was split.

Additional lightweight verification during fork PR creation:

• Confirmed branch pr/runtime-ui-bugfixes is at ba5353c.
• Confirmed push to kdegeek/hivekeep succeeded and branch tracks fork/pr/runtime-ui-bugfixes.
• Confirmed git diff --check against upstream main exits successfully for this branch.

[MarlBurroW]

Thanks @kdegeek for another substantial PR! There is genuinely good work in here: the pending tool-preview normalization fixes a real rendering gap, the shell-tools realpath fix is a proper hermeticity improvement, and the crash-safe pre-inserted assistant row attacks a real restart-replay problem. We test-merged the branch onto current main, ran typecheck plus the full suite (green), and booted the merged app through a full LLM turn.

We cannot land it as is though: three blockers, plus a large part of the Codex work has been superseded on main since you branched (main is 100+ commits ahead).

Blockers

1. The toolset-resolver change breaks onboarding. filterToolboxGrantedToolNames strips every defaultDisabled tool from all toolbox grants, including tools a toolbox lists explicitly by name. The built-in configurator toolbox explicitly lists create_agent, update_agent and restart_platform (all defaultDisabled), and Queenie's only grant source is that toolbox, so after this change she cannot create agents and onboarding is dead. It also turns explicitly checked entries in user-created toolboxes into dead affordances. The grant semantics here are settled project design: allowed = CORE ∪ toolbox names ∪ per-agent extras, where listing a tool in a toolbox IS the grant. If the concern is the * wildcard expanding to dangerous tools, the right scope is to filter defaultDisabled only inside the wildcard expansion, never from explicitly named grants.
2. The restart confirmation gate only works in English. textMentionsRestart requires the literal words restart/reboot and responseLooksAffirmative requires yes/confirm/etc., but prompt_human questions and option values are authored by the agent in the user's language (10 locales are supported). On a French instance the agent asks "Redémarrer Hivekeep ?" and stores "oui", so the gate fails closed forever and restart_platform becomes unusable. The text matching is also weak in the other direction: any answered confirm mentioning a restart of anything (a cron, an email sync) within the 10-minute window authorizes a platform restart. A structured correlation would be robust in both directions: make prompt_id required, or tag the prompt with an explicit purpose field, instead of regexing agent-authored natural language.
3. _anthropic-oauth-auth.ts can now crash the server at boot. getRealHome() throws when HOME/REAL_HOME are unset or relative and USER is unset, and it runs at module load time. A container or systemd unit without HOME/USER goes from a soft "credentials not found" to a hard boot crash, even when that provider is never used. Your own _codex-auth.ts returns envHome in the same case; doing the same here fixes it.

Superseded by main

The Codex model-catalog area was rebuilt on main after your branch point: it now fetches the live per-account catalog (GET /codex/models?client_version=...), falls back to the CLI cache, then a one-entry static floor, derives reasoning levels and modalities from backend metadata, and auth moved to a vault-first getCodexOAuthCredentials(config) flow. The expanded hardcoded fallback list and its test conflict with both the new code and the project rule against hardcoded model ids, so on a rebase those resolve to main's versions. The salvageable pieces are your multi-candidate models_cache.json path resolution (macOS and nonstandard homes) and the HOME-path candidates in the two auth helpers (with blocker 3 fixed); both would make a nice small patch against current main. Same story for package.json and telegram.test.ts: main already bumped the typecheck heap and fixed the flaky telegram test differently, and test:e2e was removed on purpose (the Playwright suite is gone).

Also worth addressing

• Pre-inserted assistant row, crash window: if the process dies between the pre-insert and the first checkpoint, an empty assistant row (content: '', no toolCalls) stays in the DB and Anthropic rejects every later turn (the guard comment the PR removes describes this exact trap). It needs a boot-recovery sweep for empty assistant rows, or the insert deferred to the first checkpoint.
• messages.ts mid-stream mount: suppressing streamingMessage when the pre-inserted row is in the page means a client mounting mid-stream never seeds its streaming bubble and sees a frozen partial until chat:done. Better to return the snapshot anyway and let the client reconcile against the listed row.
• useAgents hydrate: writing isProcessing: false for every agent means a slow /agents response finishing after a queue:update clobbers fresher SSE state (the stale-refetch trap from sse.md). The new agent:error handler also clears the main-turn spinner on quick-lane errors because it does not check taskId/sessionId like the chat:done handler does.
• Missing locale keys: tools.status.pending, tools.renderers.editingFile and tools.renderers.writingFile exist in no locale file, so the English defaultValue leaks into all 10 locales. Please add them to en.json and the other locales and run bun scripts/check-locales.ts.

Suggested path

Splitting this would get most of it merged quickly:

• (a) a small PR with the tool-preview normalization, the pending renderer states (with locale keys) and the shell-tools realpath fix, rebased on main: easily mergeable;
• (b) the crash-safe pre-insert/checkpoint work with the two streaming/SSE items above addressed;
• (c) a small patch for the multi-candidate auth and cache paths;
• and for the restart gating and the toolbox semantics, let's agree on the design here first before more code.

Thanks again for the deep work. The direction on tool previews and restart safety is right and we want most of this in.

[kdegeek]

Closing this in favor of the smaller, rebased splits suggested in review:

• Tool previews + pending renderer states → fix(ui): normalize pending tool-call previews + pending renderer states (split 1 of #27) #32 (merged)
• Codex/OAuth home-path resolution → fix(codex/oauth): resolve cache & credential paths under the real home on macOS (split 2 of #27) #33
• Crash-safe pre-insert / mid-stream: superseded — main already inserts the assistant row at end-of-turn and serves in-flight content from the in-memory activeAgentStreams snapshot, so there's no empty-row crash window to fix. The one remaining item is a useAgents stuck-spinner fix (clear on refetch without the stale-refetch clobber; guard agent:error on taskId/sessionId) — I'll open that separately.