Skip to content

Improve WTMI build for git-less systems.#30

Open
matwey wants to merge 1 commit into
MarvellEmbeddedProcessors:masterfrom
matwey:nogit
Open

Improve WTMI build for git-less systems.#30
matwey wants to merge 1 commit into
MarvellEmbeddedProcessors:masterfrom
matwey:nogit

Conversation

@matwey
Copy link
Copy Markdown
Contributor

@matwey matwey commented Feb 17, 2022

This is particularly useful when the sources are packaged in a tarball.

Signed-off-by: Matwey V. Kornilov matwey.kornilov@gmail.com

This is particularly useful when the sources are packaged in a tarball.

Signed-off-by: Matwey V. Kornilov <matwey.kornilov@gmail.com>
Copy link
Copy Markdown
Contributor

@pali pali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point here is to include full version of WTMI into BUILD_STRING which is printed by wtmi firmware at runtime over UART. There are too many WTMI builds on internet and this version string, including commit id, is the only identifier to figure out what the is the exact version of running WTMI version. When debugging WTMI firmware, people just put debug log and so it is required to have this string in it. And I helped to debug more issues in WTMI just based on version strings.

This change is removing version and commit id and therefore makes debugging of community builds harder or probably impossible. So it does not improve it but instead makes it worse.

Note that there are no tarballs of WTMI (anymore) so this tarball argument does not have any sense. In case you are using Marvell SDK tarballs (which are under NDA) then ask your Marvell representative and not community builds.

Due to debugging issues with community builds I'm against this change as it basically disallow me to debug issues in community builds of this firmware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants