Modern compiler/linking support#36
Open
bschnei wants to merge 3 commits into
Open
Conversation
bool is a reserved keyword in C23 which means this typedef is a compiler error when that standard is used to compile.
This eliminates the ld warning about missing .note.GNU-stack and lets the linker know the generated object does not require an executable stack.
The assembly instruction causes a linking error with binutils 2.44+ due to this change: https://sourceware.org/pipermail/binutils/2024-June/134923.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are three changes here. One addresses the failure to build with
ldshipped withbinutils2.44 and newer as noted here. One addresses a failure to build with the C23 standard which is the default withgcc15. The last addresses a linker warning.