Open
Conversation
|
Thanks for having a go at my issues. I will say, though, that the analog lexp function isn't really needed for several of the cases. For example (lines 302-304): |
added 7 commits
April 18, 2024 10:26
Author
|
Still no change in equations. |
The use of "tmp1" and "tmp2" variables in multiple contexts in EKV3 (in expressions destined for contributions and as temporaries holding ddx()) confuses Xyce/ADMS into thinking it needs to generate code for second derivatives in every expression involving tmp1 or tmp2. Wrapping the single instance of tmp1 and tmp2 having ddx stored into them (which are then immediately used in a later computation and then discarded) inside a begin/end block and making those tmp1 and tmp2 variables block local completely fixes the misunderstanding, and Xyce/ADMS no longer generates second derivative code anywhere. This simple fix should be used if (when?) Xyce decides to import the open source version of EKV 3.02 into Xyce, if that happens before Xyce/ADMS is replaced by something good. Without this fix, Xyce/ADMS generates a huge amount of completely unnecessary second derivatives. See also Xyce/Xyce/issues/104
Isolate ddx temporary to eliminate ADMS second derivatives
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the issues from @gjcoram are solved with this PR. No change in equations. Few parameter constraints are modified and should be checked.