[iOS] Moko Resources for Strings#21
Conversation
| import kmp.android.shared.R | ||
| import kmp.shared.base.MR | ||
|
|
||
| enum class NavBarFeature(val route: String, @StringRes val titleRes: Int) { |
There was a problem hiding this comment.
You can change the titleRes from Int to StringDesc
| echo "⚙️ Checking whether Twine is installed" | ||
| if command -v twine &> /dev/null; then | ||
| echo "✅ Twine is installed" | ||
| else | ||
| echo "❌ Twine is not installed" | ||
| echo "Check https://github.com/MateeDevs/wiki/blob/master/tooling/ruby.md for more info" | ||
| fi | ||
|
|
There was a problem hiding this comment.
You should not remove twine installation check, since it is still used, twine takes strings.txt file and generates strings.xml files for each language which are then used to create MR by moko
There was a problem hiding this comment.
You are right, but Twine is no longed run in iOS project. Instead it is run by Gradle in the shared module. That’s why it didn’t make sense to me to have it in the iOS script 🙂
There was a problem hiding this comment.
I think it still needs to be installed 🤔
There was a problem hiding this comment.
Unless gradle somehow installs it – which I think it doesn't, it looks like it just executes the twine command line tool – it should be kept in the setup script.
It should be okay that it's in the iOS script.. It still needs to setup tools needed by KMP if you want to successfully build the iOS app 😅
There was a problem hiding this comment.
Ok, got it. I have returned the check, but placed it above ./generate-strings.sh in the script as this step uses the Twine tool.
|
When I look at the task swiftgen should be removed since it is no longer necessary, does this PR contain the removal of swiftgen? |
No, Swiftgen is still in use for asset generation. Moko is used just for strings. |
|
MatuskaDev
force-pushed
the
feature/ios/moko
branch
from
34fc0ad to
900f6d1
Compare
tomas-bat
left a comment
tomas-bat
left a comment
There was a problem hiding this comment.
Not really related to this PR, but.. Does Moko allow using semantic string identifiers? Such as MR.strings().home.title, .settings.title etc.
It's something I personally prefer, so I'd be curious if it's possible with Moko 😅
|
Also, do the previews work for you after in this PR? They worked prior to this 😢 The |
Yeah, @JuliaJakubcova added the fix from DevStack to this PR and the previews work well for me. It’s weird that it does not work on your side |
|
@MatuskaDev do the previews work for you even for |
Unfortunately that doesn’t seem possible with Moko at the moment 😢 |
Yeah but it doesn't include the last change from MateeDevs/devstack-native-app#114, which was getting rid of the |
Done, please check it 🙏 |
tomas-bat
left a comment
tomas-bat
left a comment
There was a problem hiding this comment.
Done, please check it 🙏
Yup, thanks 👍
I can't test the previews since mine are still broken, so I believe you that they still work 😅
3 participants
📝 Description