sql: Force MRE::typ() to return canonical repr types#35003
Merged
ggevay merged 4 commits intoMaterializeInc:mainfrom Feb 13, 2026
Merged
sql: Force MRE::typ() to return canonical repr types#35003ggevay merged 4 commits intoMaterializeInc:mainfrom
MRE::typ() to return canonical repr types#35003ggevay merged 4 commits intoMaterializeInc:mainfrom
Conversation
Pre-merge checklist
|
…e nullability correctly, add regression test
mgree
force-pushed
the
repr-types-takeover-typ
branch
from
0cf937b to
78896a8
Compare
mgree
force-pushed
the
repr-types-takeover-typ
branch
2 times, most recently
from
742754c to
99e42eb
Compare
Contributor
Author
|
earlier nightly run that desynced after |
mgree
force-pushed
the
repr-types-takeover-typ
branch
from
99e42eb to
aa476af
Compare
ggevay
pushed a commit
that referenced
this pull request
Feb 13, 2026
) ### Motivation #34958 removed many possible panics; #35003 sussed out another. ### Description We should only panic when types well and truly don't match---if SQL types don't align but repr types do, there is no possibility of runtime error. ### Verification Nightly, baby! This failure got sussed out by #35003, which pushes repr types into many new locations---it is likely not a reachable failure in the existing code.
Contributor
|
Green! One more random Nightly run: https://buildkite.com/materialize/nightly/builds/15146 |
ggevay
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#27239
Description
Changes
MirRelationExpr::typ()to actually do repr type inference, not SQL type. While it still returns a SQL type (to be fixed in a later PR), it's a canonical SQL type, obtained by mapping repr types back up to SQL types.This draft PR is on top of #35005, which should merge first.
Verification
Currently WIP.
Will with nightly that #34958 successfully avoids all panics.